Skip to content

Commit

Permalink
Fix Project Build and Deploy exit status (elastic#172113)
Browse files Browse the repository at this point in the history
## Summary

The last line of the script will evaluate to false if the security label
is not set, which results in the exit status being reported as 1
(failure), but the project is actually deployed properly.


[Example](https://buildkite.com/elastic/kibana-pull-request/builds/179784#018c17c0-5dd6-4e1f-b6ef-73fa50e1de74/4142-4148)
  • Loading branch information
Ikuni17 authored Nov 29, 2023
1 parent b5efbf2 commit 57118a3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .buildkite/scripts/steps/serverless/build_and_deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,5 @@ EOF
is_pr_with_label "ci:project-deploy-elasticsearch" && deploy "elasticsearch"
is_pr_with_label "ci:project-deploy-observability" && deploy "observability"
is_pr_with_label "ci:project-deploy-security" && deploy "security"

exit 0;

0 comments on commit 57118a3

Please sign in to comment.