Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change typeset to typelist for cdc #48

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sourcecd
Copy link
Contributor

@sourcecd sourcecd commented Feb 5, 2025

changed TypeSet to TypeList because TypeSet very slow for many items

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 28 lines in your changes missing coverage. Please review.

Project coverage is 14.24%. Comparing base (ffd1180) to head (57ae44a).

Files with missing lines Patch % Lines
internal/resources/changefeed/changefeed.go 0.00% 12 Missing ⚠️
internal/resources/changefeed/update.go 0.00% 11 Missing ⚠️
internal/resources/changefeed/create.go 0.00% 3 Missing ⚠️
sdk/terraform/table/changefeed/resource.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   13.03%   14.24%   +1.20%     
==========================================
  Files          69       69              
  Lines        4856     4936      +80     
==========================================
+ Hits          633      703      +70     
- Misses       4201     4211      +10     
  Partials       22       22              
Flag Coverage Δ
go-1.21.x 14.24% <71.42%> (?)
go-1.22.x 14.24% <71.42%> (+1.20%) ⬆️
macOS 14.24% <71.42%> (?)
ubuntu 14.24% <71.42%> (?)
unit 14.24% <71.42%> (+1.20%) ⬆️
windows 14.24% <71.42%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sourcecd sourcecd requested a review from shmel1k February 10, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants