Regenerate crds with new controller-gen #274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
apply
controller-gen
0.6.1. The build with controller-gen 0.6.1 failed on go 1.22 and has been upgraded to 0.16.5 by @sourcecd in a recent PR.What is the new behavior?
make manifests
inupload-artifacts
pipeline to ensure the source of truth is the golang specificationMost of the diff is reformatted
description
fields (some lines are shorter, some are longer, just plain text changes of an openAPIV3Schema). Turns out, the diff is not +13000-13000, but rather +1-30 (see below, this diff is attached), if we filter thedescription
field out. The only ESSENTIAL change is the following:the
name
field of a remote database nodeset is a required attribute now-30 lines are because of the
status
field being removed. This field shouldn't be persisted to a repository, probably someone took it from a living cluster way back in 2021? Anyway, it is safe to delete it.I have tested installing Storage + Database from new CRDs as well as upgrading the CRDs while the Storage + Database are deployed already. No errors have occured, as expected.