Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObservedGeneration in conditions #275

Merged
merged 22 commits into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
36f243a
fix remoteObj resourceVersion log
kobzonega May 17, 2024
e2f6659
Merge branch 'master' into fix-remoteObjRV-log
kobzonega Jul 4, 2024
512979e
observedGeneration for conditions
kobzonega Jul 5, 2024
a1eedd9
Merge branch 'fix-remoteObjRV-log'
kobzonega Jul 5, 2024
e8d4c1a
fixes messages
kobzonega Jul 17, 2024
ebbf26d
Merge remote-tracking branch 'origin' into fix-remoteObjRV-log
kobzonega Jul 17, 2024
1eaae78
fixed condition status const
kobzonega Jul 17, 2024
3a584fe
do not append ObservedGeneration for RemoteResource conditions
kobzonega Jul 17, 2024
e7784f9
condition on first generation without ObservedGeneration field
kobzonega Jul 17, 2024
62a9074
YDBOPS-9692 move encryption config to args (#217)
kobzonega Jul 18, 2024
10f06a6
revert backward compatibility for encryption key secret (#243)
kobzonega Aug 20, 2024
589ab08
Remove datastreams iam sa key (#242)
mvgorbunov Aug 22, 2024
6ee0322
Update CONTRIBUTING.md (#245)
alexv-smirnov Aug 27, 2024
bd07ed1
fix encryption config ID backward compatibility (#244)
kobzonega Aug 28, 2024
babe450
Update PULL_REQUEST_TEMPLATE.md (#246)
alexv-smirnov Sep 5, 2024
286d3f8
Enable 3 node deployment for testing purposes (#248)
Jorres Sep 24, 2024
7da8c77
Merge branch 'master' into fix-remoteObjRV-log
kobzonega Sep 26, 2024
4c59ff7
observedGeneration for all SetStatusCondition
kobzonega Dec 4, 2024
e43f7a6
Merge remote-tracking branch 'origin' into observed-generation
kobzonega Dec 4, 2024
455a884
changie info
kobzonega Jan 27, 2025
194dc1b
move changes in another pr
kobzonega Jan 27, 2025
c295acd
handle syncNodeSetSpecInline inside handleResourcesSync func
kobzonega Jan 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/Added-20250127-130609.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Added
body: field ObservedGeneration inside .status.conditions
time: 2025-01-27T13:06:09.845302+08:00
63 changes: 35 additions & 28 deletions internal/controllers/database/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ func (r *Reconciler) setInitPipelineStatus(
) (bool, ctrl.Result, error) {
if database.Status.State == DatabasePreparing {
meta.SetStatusCondition(&database.Status.Conditions, metav1.Condition{
Type: DatabaseInitializedCondition,
Status: metav1.ConditionFalse,
Reason: ReasonInProgress,
Message: "Database has not been initialized yet",
Type: DatabaseInitializedCondition,
Status: metav1.ConditionFalse,
Reason: ReasonInProgress,
ObservedGeneration: database.Generation,
Message: "Database has not been initialized yet",
})
database.Status.State = DatabaseInitializing
return r.updateStatus(ctx, database, StatusUpdateRequeueDelay)
Expand Down Expand Up @@ -58,16 +59,18 @@ func (r *Reconciler) setInitDatabaseCompleted(
message string,
) (bool, ctrl.Result, error) {
meta.SetStatusCondition(&database.Status.Conditions, metav1.Condition{
Type: DatabaseInitializedCondition,
Status: metav1.ConditionTrue,
Reason: ReasonCompleted,
Message: message,
Type: DatabaseInitializedCondition,
Status: metav1.ConditionTrue,
Reason: ReasonCompleted,
ObservedGeneration: database.Generation,
Message: message,
})
meta.SetStatusCondition(&database.Status.Conditions, metav1.Condition{
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionTrue,
Reason: ReasonCompleted,
Message: "Tenant creation operation is completed",
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionTrue,
Reason: ReasonCompleted,
ObservedGeneration: database.Generation,
Message: "Tenant creation operation is completed",
})
return r.updateStatus(ctx, database, StatusUpdateRequeueDelay)
}
Expand All @@ -90,10 +93,11 @@ func (r *Reconciler) checkCreateDatabaseOperation(
errMessage,
)
meta.SetStatusCondition(&database.Status.Conditions, metav1.Condition{
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionFalse,
Reason: ReasonFailed,
Message: errMessage,
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionFalse,
Reason: ReasonFailed,
ObservedGeneration: database.Generation,
Message: errMessage,
})
return r.updateStatus(ctx, database, DatabaseInitializationRequeueDelay)
}
Expand Down Expand Up @@ -124,10 +128,11 @@ func (r *Reconciler) checkCreateDatabaseOperation(
errMessage,
)
meta.SetStatusCondition(&database.Status.Conditions, metav1.Condition{
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionFalse,
Reason: ReasonCompleted,
Message: errMessage,
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionFalse,
Reason: ReasonCompleted,
ObservedGeneration: database.Generation,
Message: errMessage,
})
return r.updateStatus(ctx, database, DatabaseInitializationRequeueDelay)
}
Expand All @@ -140,10 +145,11 @@ func (r *Reconciler) checkCreateDatabaseOperation(
fmt.Sprintf("Tenant creation operation is not completed, operationID: %s", operationID),
)
meta.SetStatusCondition(&database.Status.Conditions, metav1.Condition{
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionUnknown,
Reason: ReasonInProgress,
Message: operationID,
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionUnknown,
Reason: ReasonInProgress,
ObservedGeneration: database.Generation,
Message: operationID,
})
return r.updateStatus(ctx, database, DatabaseInitializationRequeueDelay)
}
Expand Down Expand Up @@ -296,10 +302,11 @@ func (r *Reconciler) initializeTenant(
fmt.Sprintf("Tenant creation operation in progress, operationID: %s", operationID),
)
meta.SetStatusCondition(&database.Status.Conditions, metav1.Condition{
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionUnknown,
Reason: ReasonInProgress,
Message: operationID,
Type: CreateDatabaseOperationCondition,
Status: metav1.ConditionUnknown,
Reason: ReasonInProgress,
ObservedGeneration: database.Generation,
Message: operationID,
})
return r.updateStatus(ctx, database, DatabaseInitializationRequeueDelay)
}
Expand Down
Loading
Loading