Skip to content

Commit

Permalink
switch off stream idx lookup join by default before 25-1 (#13737)
Browse files Browse the repository at this point in the history
  • Loading branch information
@gridnevvvit
gridnevvvit authored Jan 22, 2025
1 parent ffff404 commit 239f04b
Show file tree
Hide file tree
Showing 59 changed files with 5,887 additions and 2,657 deletions.
2 changes: 1 addition & 1 deletion ydb/core/kqp/ut/perf/kqp_query_perf_ut.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ Y_UNIT_TEST_SUITE(KqpQueryPerf) {
if (settings.AppConfig.GetTableServiceConfig().GetEnableKqpDataQueryStreamIdxLookupJoin()) {
UNIT_ASSERT_VALUES_EQUAL(stats.query_phases().size(), 1);
} else if (settings.AppConfig.GetTableServiceConfig().GetEnableKqpDataQueryStreamLookup()) {
UNIT_ASSERT_VALUES_EQUAL(stats.query_phases().size(), 3);
UNIT_ASSERT_VALUES_EQUAL(stats.query_phases().size(), 2);
} else {
UNIT_ASSERT_VALUES_EQUAL(stats.query_phases().size(), 5);
}
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/protos/table_service_config.proto
View file
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ message TTableServiceConfig {
reserved 33; // optional bool EnableKqpDataQueryStreamPointLookup = 33 [default = false];
optional bool EnablePublishKqpProxyByRM = 34 [default = true];
optional bool EnableKqpScanQueryStreamIdxLookupJoin = 35 [default = false];
optional bool EnableKqpDataQueryStreamIdxLookupJoin = 49 [default = true];
optional bool EnableKqpDataQueryStreamIdxLookupJoin = 49 [default = false];
reserved 36; //optional bool EnablePredicateExtractForScanQueries = 36 [default = true];
reserved 37; //optional bool EnablePredicateExtractForDataQueries = 37 [default = true];
reserved 38; // optional bool EnableKqpImmediateEffects = 38 [default = true];
Expand Down
280 changes: 193 additions & 87 deletions ...calFolder1.test_case_join_group_by_lookup.script-script_/join_group_by_lookup.script.plan
View file

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions ...nicalFolder1.test_case_join_join_double_lookup.sql-plan_/join_join_double_lookup.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,7 @@
"Key1",
"Key2"
],
"lookup_by": [
"Key1"
],
"type": "Lookup"
"type": "Scan"
}
]
}
Expand Down
5 changes: 1 addition & 4 deletions ...older1.test_case_join_join_dup_column_right.sql-plan_/join_join_dup_column_right.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@
"Key1",
"Key2"
],
"lookup_by": [
"Key1"
],
"type": "Lookup"
"type": "Scan"
}
]
}
Expand Down
4 changes: 0 additions & 4 deletions ...CanonicalFolder1.test_case_join_join_range_right.sql-plan_/join_join_range_right.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
7 changes: 0 additions & 7 deletions ...nicalFolder1.test_case_join_join_to_idx_lookup.sql-plan_/join_join_to_idx_lookup.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
"Key1",
"Key2"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand All @@ -45,9 +41,6 @@
"Key",
"Value"
],
"lookup_by": [
"Key"
],
"type": "Lookup"
}
]
Expand Down
4 changes: 0 additions & 4 deletions ...r1.test_case_join_join_to_idx_lookup_cast.sql-plan_/join_join_to_idx_lookup_cast.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
5 changes: 1 addition & 4 deletions ....test_case_join_join_to_idx_lookup_cast2.sql-plan_/join_join_to_idx_lookup_cast2.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1"
],
"type": "Lookup"
"type": "Scan"
}
]
}
Expand Down
4 changes: 0 additions & 4 deletions ..._join_join_to_idx_lookup_dup_c_left.sql-plan_/join_join_to_idx_lookup_dup_c_left.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
4 changes: 0 additions & 4 deletions ...r1.test_case_join_join_to_idx_lookup_equi.sql-plan_/join_join_to_idx_lookup_equi.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
7 changes: 0 additions & 7 deletions ....test_case_join_join_to_idx_lookup_inner.sql-plan_/join_join_to_idx_lookup_inner.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
"Key1",
"Key2"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand All @@ -45,9 +41,6 @@
"Key",
"Value"
],
"lookup_by": [
"Key"
],
"type": "Lookup"
}
]
Expand Down
3 changes: 0 additions & 3 deletions ...case_join_join_to_idx_lookup_leftonly.sql-plan_/join_join_to_idx_lookup_leftonly.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
"columns": [
"Key"
],
"lookup_by": [
"Key"
],
"type": "Lookup"
}
]
Expand Down
4 changes: 0 additions & 4 deletions ...case_join_join_to_idx_lookup_leftsemi.sql-plan_/join_join_to_idx_lookup_leftsemi.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
"Key1",
"Key2"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
8 changes: 1 addition & 7 deletions ...join_to_idx_lookup_partial_inner.sql-plan_/join_join_to_idx_lookup_partial_inner.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@
"Key1",
"Value"
],
"lookup_by": [
"Key1"
],
"type": "Lookup"
"type": "Scan"
}
]
},
Expand All @@ -43,9 +40,6 @@
"Key",
"Value"
],
"lookup_by": [
"Key"
],
"type": "Lookup"
}
]
Expand Down
5 changes: 1 addition & 4 deletions ..._to_idx_lookup_partial_lefonly.sql-plan_/join_join_to_idx_lookup_partial_lefonly.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@
"columns": [
"Key1"
],
"lookup_by": [
"Key1"
],
"type": "Lookup"
"type": "Scan"
}
]
}
Expand Down
5 changes: 1 addition & 4 deletions ..._to_idx_lookup_partial_lefsemi.sql-plan_/join_join_to_idx_lookup_partial_lefsemi.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@
"columns": [
"Key1"
],
"lookup_by": [
"Key1"
],
"type": "Lookup"
"type": "Scan"
}
]
}
Expand Down
8 changes: 1 addition & 7 deletions ...n_join_to_idx_lookup_partial_left.sql-plan_/join_join_to_idx_lookup_partial_left.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@
"Key1",
"Value"
],
"lookup_by": [
"Key1"
],
"type": "Lookup"
"type": "Scan"
}
]
},
Expand All @@ -43,9 +40,6 @@
"Key",
"Value"
],
"lookup_by": [
"Key"
],
"type": "Lookup"
}
]
Expand Down
5 changes: 1 addition & 4 deletions ...lookup_predicate_left_null.sql-plan_/join_join_to_idx_lookup_predicate_left_null.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@
"Key1",
"Value"
],
"lookup_by": [
"Key1"
],
"type": "Lookup"
"type": "Scan"
}
]
}
Expand Down
4 changes: 0 additions & 4 deletions ..._to_idx_lookup_predicate_right.sql-plan_/join_join_to_idx_lookup_predicate_right.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
4 changes: 0 additions & 4 deletions ...idx_lookup_predicate_right_2.sql-plan_/join_join_to_idx_lookup_predicate_right_2.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
4 changes: 0 additions & 4 deletions ..._join_join_to_idx_lookup_range_left.sql-plan_/join_join_to_idx_lookup_range_left.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
4 changes: 0 additions & 4 deletions ..._to_idx_lookup_right_key_range.sql-plan_/join_join_to_idx_lookup_right_key_range.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
4 changes: 0 additions & 4 deletions ...case_join_join_to_idx_lookup_simple_c.sql-plan_/join_join_to_idx_lookup_simple_c.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
"Key2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand Down
9 changes: 1 addition & 8 deletions ...CanonicalFolder1.test_case_join_join_using_index.sql-plan_/join_join_using_index.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@
"Fk2",
"Value"
],
"lookup_by": [
"Key1",
"Key2"
],
"type": "Lookup"
}
]
Expand All @@ -43,10 +39,7 @@
"Key1",
"Key2"
],
"lookup_by": [
"Fk2"
],
"type": "Lookup"
"type": "Scan"
}
]
}
Expand Down
6 changes: 0 additions & 6 deletions ...l.TestCanonicalFolder1.test_case_join_join_with_agg.sql-plan_/join_join_with_agg.sql.plan
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@
},
{
"columns": [
"Fk21",
"Fk22",
"Key",
"Value"
],
"lookup_by": [
"Key"
],
"type": "Lookup"
Expand Down
Loading

0 comments on commit 239f04b

Please sign in to comment.