Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Superset docs after adding native driver support #12143

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update Superset docs after adding native driver support #12143

wants to merge 3 commits into from

Conversation

vgvoleg
Copy link
Contributor

@vgvoleg vgvoleg commented Nov 29, 2024

Changelog entry

...

Changelog category

  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

DO NOT MERGE until apache/superset#31141 is merged.

@vgvoleg vgvoleg requested a review from a team as a code owner November 29, 2024 13:25
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

⚪ 2024-11-29 13:28:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for d23f5b4 has started.
⚪ 2024-11-29 13:29:21 UTC Artifacts will be uploaded here
⚪ 2024-11-29 13:32:11 UTC ya make is running...
🟢 2024-11-29 13:33:39 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-29 13:33:49 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

⚪ 2024-11-29 13:33:41 UTC Pre-commit check linux-x86_64-release-asan for d23f5b4 has started.
⚪ 2024-11-29 13:33:52 UTC Artifacts will be uploaded here
⚪ 2024-11-29 13:36:17 UTC ya make is running...
🟢 2024-11-29 13:36:22 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-29 13:36:27 UTC Build successful.

@vgvoleg vgvoleg force-pushed the update_superset_docs branch from 0ac1313 to 9385fef Compare November 29, 2024 13:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

⚪ 2024-11-29 13:46:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for f65159e has started.
⚪ 2024-11-29 13:47:10 UTC Artifacts will be uploaded here
⚪ 2024-11-29 13:49:36 UTC ya make is running...
🟢 2024-11-29 13:50:58 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-29 13:51:04 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

⚪ 2024-11-29 13:49:22 UTC Pre-commit check linux-x86_64-release-asan for f65159e has started.
⚪ 2024-11-29 13:49:34 UTC Artifacts will be uploaded here
⚪ 2024-11-29 13:51:59 UTC ya make is running...
🟢 2024-11-29 13:52:05 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-29 13:52:11 UTC Build successful.

blinkov
blinkov requested changes Dec 3, 2024
View reviewed changes
ydb/docs/en/core/integrations/visualization/superset.md Outdated Show resolved Hide resolved
ydb/docs/en/core/integrations/visualization/superset.md Outdated Show resolved Hide resolved
ydb/docs/en/core/integrations/visualization/_includes/toc-table.md Outdated Show resolved Hide resolved
ydb/docs/en/core/integrations/visualization/superset.md Outdated Show resolved Hide resolved
ydb/docs/en/core/integrations/visualization/superset.md

4. Enter the SQL query in the right section of the page. For example, `SELECT * FROM <ydb_table_name>`.
1. Enter the SQL query in the right section of the page. For example, `SELECT * FROM <ydb_table_name>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given users are entering queries manually, they might still prefer to use the PostgreSQL dialect if they're more familiar with it. Let's keep both options documented?

@blinkov
Copy link
Member

blinkov commented Feb 10, 2025

@vgvoleg, do you intend to finish this?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

⚪ 2025-02-10 09:50:31 UTC Pre-commit check linux-x86_64-release-asan for af2765e has started.
⚪ 2025-02-10 09:50:44 UTC Artifacts will be uploaded here
⚪ 2025-02-10 09:53:20 UTC ya make is running...
🟢 2025-02-10 09:54:56 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-02-10 09:55:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

⚪ 2025-02-10 09:51:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for af2765e has started.
⚪ 2025-02-10 09:51:47 UTC Artifacts will be uploaded here
⚪ 2025-02-10 09:54:14 UTC ya make is running...
🟢 2025-02-10 09:55:17 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-02-10 09:55:23 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

⚪ 2025-02-10 10:11:22 UTC Pre-commit check linux-x86_64-release-asan for 71acc48 has started.
⚪ 2025-02-10 10:11:34 UTC Artifacts will be uploaded here
⚫ 2025-02-10 10:12:34 UTC Check cancelled

@vgvoleg vgvoleg force-pushed the update_superset_docs branch from 105939e to 46a25c5 Compare February 10, 2025 10:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

⚪ 2025-02-10 10:12:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 71acc48 has started.
⚫ 2025-02-10 10:12:29 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

⚪ 2025-02-10 10:14:36 UTC Pre-commit check linux-x86_64-release-asan for 10681ec has started.
⚪ 2025-02-10 10:14:48 UTC Artifacts will be uploaded here
⚪ 2025-02-10 10:17:24 UTC ya make is running...
🟢 2025-02-10 10:18:55 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-02-10 10:19:01 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

⚪ 2025-02-10 10:16:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 10681ec has started.
⚪ 2025-02-10 10:16:32 UTC Artifacts will be uploaded here
⚪ 2025-02-10 10:19:15 UTC ya make is running...
🟢 2025-02-10 10:19:21 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-02-10 10:19:27 UTC Build successful.

@vgvoleg vgvoleg requested a review from blinkov February 10, 2025 10:20
@vgvoleg vgvoleg changed the title Draft: Update Superset docs after adding native driver support Update Superset docs after adding native driver support Feb 10, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blinkov blinkov Awaiting requested review from blinkov

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgvoleg @blinkov