-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Data Sources: RPC implementation for the describe methods + ydb scheme describe support #14509
External Data Sources: RPC implementation for the describe methods + ydb scheme describe support #14509
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
611d523
to
9807afd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI part LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDK LGTM
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Implement describe external data sources / external tables RPCs. The implementations of the RPCs are almost identical and require deduplication (probably, via a common base class for both RPC implementation classes). However, we are in a hurry and this task:
will be done separately.
ydb scheme describe
is also half-baked (only the--format proto-json-base64
works as intended). Pretty format will be done in the next PRs in the series.Note: YDB CLI is released separately and more often than YDB server versions. Users might end up with a newer CLI that supports enhanced external data source and table descriptions, but the server does not implement the RPCs yet. This users would get an error when they attempt to call the NYdb::NTable::TSession::DescribeExternalDataSource or DescribeExternalTable methods. This is a minor inconvenience, but not a blocker in my opinion. Only the targeted calls like
ydb scheme describe my_external_data_source
will fail (side note:ydb scheme ls -l -R
does not use the new RPCs), so the existing user scripts should be just fine.Changelog entry
Changelog category
Additional information