Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix busywait on adding to full async input buffer #14522

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Feb 13, 2025

DoExecute->PollAsyncInput->source.PollAsyncInput->ContinueExecution->DoExecute...

Changelog entry

...

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

Somewhat reverts YQ-1612, needs careful checks/review
...

DoExecute->PollAsyncInput->source.PollAsyncInput->ContinueExecution->DoExecute...
Copy link

github-actions bot commented Feb 13, 2025

2025-02-13 10:06:06 UTC Pre-commit check linux-x86_64-release-asan for abd1799 has started.
2025-02-13 10:06:17 UTC Artifacts will be uploaded here
2025-02-13 10:09:06 UTC ya make is running...
🟡 2025-02-13 11:43:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11645 11562 0 34 13 36

2025-02-13 11:44:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-13 12:06:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 92 0 1 4 33

2025-02-13 12:06:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-13 12:18:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 31 0 1 2 34

🟢 2025-02-13 12:18:42 UTC Build successful.
🟢 2025-02-13 12:19:11 UTC ydbd size 3.6 GiB changed* by -176 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 749f7cd merge: abd1799 diff diff %
ydbd size 3 878 463 792 Bytes 3 878 463 616 Bytes -176 Bytes -0.000%
ydbd stripped size 1 358 247 648 Bytes 1 358 247 584 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 13, 2025

2025-02-13 10:06:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for abd1799 has started.
2025-02-13 10:06:42 UTC Artifacts will be uploaded here
2025-02-13 10:09:34 UTC ya make is running...
🟡 2025-02-13 11:08:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25801 23197 0 6 2467 131

2025-02-13 11:11:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-13 11:28:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 85 0 3 2 128

2025-02-13 11:28:45 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-13 11:43:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
197 (only retried tests) 70 0 2 0 125

🟢 2025-02-13 11:43:52 UTC Build successful.
🟢 2025-02-13 11:44:15 UTC ydbd size 2.1 GiB changed* by -2.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 749f7cd merge: abd1799 diff diff %
ydbd size 2 230 113 376 Bytes 2 230 111 120 Bytes -2.2 KiB -0.000%
ydbd stripped size 473 416 696 Bytes 473 416 568 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant