Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25-1: ReadTable and ReadRows RPC fixes (#15721, #15850) #16799

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

lex007in
Copy link
Collaborator

@lex007in lex007in commented Apr 4, 2025

Changelog entry

Changelog category

  • Bugfix

Description for reviewers

Copy link

github-actions bot commented Apr 4, 2025

🟢 2025-04-07 12:08:00 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 16:43:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9d19d45 has started.
2025-04-04 16:44:22 UTC Artifacts will be uploaded here
2025-04-04 16:47:39 UTC ya make is running...
🟡 2025-04-04 17:41:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19282 17918 0 3 1224 137

2025-04-04 17:44:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-04 18:06:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 77 0 0 1 129

🟢 2025-04-04 18:06:26 UTC Build successful.
🟢 2025-04-04 18:06:48 UTC ydbd size 2.1 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 8ce06a5 merge: 9d19d45 diff diff %
ydbd size 2 244 279 904 Bytes 2 244 284 424 Bytes +4.4 KiB +0.000%
ydbd stripped size 475 196 856 Bytes 475 197 880 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 16:44:57 UTC Pre-commit check linux-x86_64-release-asan for 9d19d45 has started.
2025-04-04 16:45:19 UTC Artifacts will be uploaded here
2025-04-04 16:48:15 UTC ya make is running...
🟡 2025-04-04 18:05:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12024 11935 0 46 10 33

2025-04-04 18:07:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-04 18:28:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
140 (only retried tests) 104 0 0 5 31

🟢 2025-04-04 18:28:30 UTC Build successful.
🟢 2025-04-04 18:28:57 UTC ydbd size 3.6 GiB changed* by +9.8 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 8ce06a5 merge: 9d19d45 diff diff %
ydbd size 3 904 012 720 Bytes 3 904 022 704 Bytes +9.8 KiB +0.000%
ydbd stripped size 1 366 024 912 Bytes 1 366 029 200 Bytes +4.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lex007in lex007in marked this pull request as ready for review April 7, 2025 11:40
@lex007in lex007in requested a review from a team as a code owner April 7, 2025 11:40
@lex007in lex007in merged commit 8be911b into ydb-platform:stable-25-1 Apr 7, 2025
16 checks passed
@lex007in lex007in deleted the read_rpc_fixes branch April 7, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants