Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower log verbosity for schemeshard #16806

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Lower log verbosity for schemeshard #16806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aac3d94
Lower log verobosity for statistics in schemeshard
azevaykin Apr 5, 2025
92d2119
Remove tenants
azevaykin Apr 5, 2025
1375cd6
Update ydb/core/tx/schemeshard/schemeshard__table_stats.cpp
azevaykin Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/tx/schemeshard/schemeshard__operation_side_effects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ void TSideEffects::DoUpdateTenant(TSchemeShard* ss, NTabletFlatExecutor::TTransa
}

if (!hasChanges) {
LOG_INFO_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
LOG_DEBUG_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"DoUpdateTenant no hasChanges"
<< ", pathId: " << pathId
<< ", tenantLink: " << tenantLink
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/tx/schemeshard/schemeshard__pq_stats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ void TSchemeShard::Handle(TEvPersQueue::TEvPeriodicTopicStats::TPtr& ev, const T
}

void TSchemeShard::Handle(TEvPrivate::TEvPersistTopicStats::TPtr&, const TActorContext& ctx) {
LOG_INFO_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
LOG_DEBUG_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"Started TEvPersistStats at tablet " << TabletID() << ", queue size# " << TopicStatsQueue.Size());

TopicStatsBatchScheduled = false;
Expand Down
16 changes: 6 additions & 10 deletions ydb/core/tx/schemeshard/schemeshard__table_stats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,19 +279,15 @@ bool TTxStoreTableStats::PersistSingleStats(const TPathId& pathId,
shardInfo->BindedChannels);

const auto pathElement = Self->PathsById[pathId];
const TPartitionStats newStats = PrepareStats(ctx, rec, channelsMapping);

LOG_DEBUG_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"TTxStoreTableStats.PersistSingleStats: main stats from"
<< " datashardId(TabletID)=" << datashardId << " maps to shardIdx: " << shardIdx
<< " followerId=" << followerId
<< ", pathId: " << pathId << ", pathId map=" << pathElement->Name
<< ", is column=" << isColumnTable << ", is olap=" << isOlapStore);

const TPartitionStats newStats = PrepareStats(ctx, rec, channelsMapping);

LOG_INFO_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"Add stats from shard with datashardId(TabletID)=" << datashardId << " followerId=" << followerId
<< ", pathId " << pathId.LocalPathId
<< ": RowCount " << newStats.RowCount
<< ", is column=" << isColumnTable << ", is olap=" << isOlapStore
<< ", RowCount " << newStats.RowCount
<< ", DataSize " << newStats.DataSize
<< (newStats.HasBorrowedData ? ", with borrowed parts" : ""));

Expand Down Expand Up @@ -543,7 +539,7 @@ void TSchemeShard::Handle(TEvDataShard::TEvPeriodicTableStats::TPtr& ev, const T
? TPathId(TOwnerId(rec.GetTableOwnerId()), TLocalPathId(rec.GetTableLocalId()))
: MakeLocalId(TLocalPathId(rec.GetTableLocalId()));

LOG_INFO_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
LOG_DEBUG_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"Got periodic table stats at tablet " << TabletID()
<< " from shard " << datashardId
<< " followerId " << followerId
Expand Down Expand Up @@ -577,7 +573,7 @@ void TSchemeShard::Handle(TEvDataShard::TEvPeriodicTableStats::TPtr& ev, const T
}

void TSchemeShard::Handle(TEvPrivate::TEvPersistTableStats::TPtr&, const TActorContext& ctx) {
LOG_INFO_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
LOG_DEBUG_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"Started TEvPersistStats at tablet " << TabletID() << ", queue size# " << TableStatsQueue.Size());

TableStatsBatchScheduled = false;
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/tx/schemeshard/schemeshard_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5754,7 +5754,7 @@ void TSchemeShard::Handle(TEvTabletPipe::TEvServerDisconnected::TPtr &, const TA

void TSchemeShard::Handle(TEvSchemeShard::TEvSyncTenantSchemeShard::TPtr& ev, const TActorContext& ctx) {
const auto& record = ev->Get()->Record;
LOG_INFO_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
LOG_DEBUG_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"Handle TEvSyncTenantSchemeShard"
<< ", at schemeshard: " << TabletID()
<< ", msg: " << record.DebugString());
Expand Down
Loading