optimize objects initialization #16810
Conversation
ivanmorozov333
commented
Apr 5, 2025
ivanmorozov333
commented
- Performance improvement
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
| TStatusValidator::Validate(builder->AppendNull()); | ||
| return NArrow::FinishBuilder(std::move(builder)); | ||
| std::shared_ptr<arrow::Array> result; | ||
| NArrow::SwitchType(typePtr->id(), [&](const auto& /*type*/) { |
There was a problem hiding this comment.
А зачем здесь вызывается идентичный код, как и раньше, но через SwitchType? Это влияет на перформанс?
Я вижу только что некоторые типы в typePtr->id() приведут к падению верифайки.
There was a problem hiding this comment.
код не идентичен. verify на типах, которые не используются
