Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for 2025-04-06 #16816

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ydbot
Copy link
Collaborator

@ydbot ydbot commented Apr 6, 2025

This PR updates the CHANGELOG.md file for 2025-04-06.

@ydbot ydbot requested a review from a team as a code owner April 6, 2025 00:03
Copy link

github-actions bot commented Apr 6, 2025

2025-04-06 00:04:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 41a40d2 has started.
2025-04-06 00:04:51 UTC Artifacts will be uploaded here
2025-04-06 00:07:39 UTC ya make is running...
🟢 2025-04-06 00:07:44 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-06 00:07:50 UTC Build successful.

Copy link

github-actions bot commented Apr 6, 2025

2025-04-06 00:04:07 UTC Pre-commit check linux-x86_64-release-asan for 41a40d2 has started.
2025-04-06 00:04:15 UTC Artifacts will be uploaded here
2025-04-06 00:06:35 UTC ya make is running...
🟢 2025-04-06 00:06:41 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-06 00:06:47 UTC Build successful.

Copy link

github-actions bot commented Apr 6, 2025

🟢 2025-04-06 00:04:52 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Apr 9, 2025

2025-04-09 07:54:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 974c663 has started.
2025-04-09 07:55:02 UTC Artifacts will be uploaded here
2025-04-09 07:57:24 UTC ya make is running...
🟢 2025-04-09 07:57:29 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-09 07:57:35 UTC Build successful.

Copy link

github-actions bot commented Apr 9, 2025

2025-04-09 07:56:57 UTC Pre-commit check linux-x86_64-release-asan for 974c663 has started.
2025-04-09 07:57:14 UTC Artifacts will be uploaded here
2025-04-09 07:59:39 UTC ya make is running...
🟢 2025-04-09 07:59:45 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-09 07:59:51 UTC Build successful.

CHANGELOG.md Outdated
@@ -5,6 +5,7 @@
* 15186:Increased [the query text limit size](../dev/system-views#query-metrics) in system views from 4 KB to 10 KB. [#15186](https://github.com/ydb-platform/ydb/pull/15186) ([spuchin](https://github.com/spuchin))
* 15693:Added a health check configuration that administrators can customize: the number of node restarts, tablets, the time difference between database dynodes,
and timeout (by default, the maximum response time from healthcheck). Documentation is under construction. [#15693](https://github.com/ydb-platform/ydb/pull/15693) ([Andrei Rykov](https://github.com/StekPerepolnen))
* 16792:The patchset makes `ReplicateScalars` work only with WideStream I/O type in DQ. [#16792](https://github.com/ydb-platform/ydb/pull/16792) ([Igor Munkin](https://github.com/igormunkin))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igormunkin Привет! Подскажи, это изменение будет видно для конечного пользователя YDB?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galnat, привет. Нет, это скорее внутреннее изменение.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В таком случае стоит выбирать категорию изменения "Not for changelog". У нас есть инструкция, как заполнять описание и правильно выбрать категорию - https://ydb.tech/docs/ru/contributor/suggest-change#create_pr_desc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galhat, т.е. в случае изменений по каким-то внутренностям, связанным с YQL изменениям в Arcadia всегда стоит выбирать Not for changelog?

CHANGELOG.md Outdated
* 16423:Changed behavior — `SHOW CREATE TABLE` now fails on views instead of producing wrong output. [#16423](https://github.com/ydb-platform/ydb/pull/16423) ([Daniil Demin](https://github.com/jepett0))
* 16768:Fixed altering of max_active_partition property of the topic with YQL query [#16768](https://github.com/ydb-platform/ydb/pull/16768) ([Nikolay Shestakov](https://github.com/nshestakov))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshestakov Коля, как тебе такой вариант:
Fixed a bug where topic auto-partitioning was not working when configuration parameter max_active_partition were set via ALTER TOPIC statement.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У Коли не было возражений

CHANGELOG.md Outdated
* 16423:Changed behavior — `SHOW CREATE TABLE` now fails on views instead of producing wrong output. [#16423](https://github.com/ydb-platform/ydb/pull/16423) ([Daniil Demin](https://github.com/jepett0))
* 16768:Fixed altering of max_active_partition property of the topic with YQL query [#16768](https://github.com/ydb-platform/ydb/pull/16768) ([Nikolay Shestakov](https://github.com/nshestakov))
* 16764:Fixed redirects in describe handler closes #16763 [#16764](https://github.com/ydb-platform/ydb/pull/16764) ([Alexey Efimov](https://github.com/adameat))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adameat подскажи, это заметное для конечного пользователя изменение? какой именно редирект у него не работал?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adameat подскажи, это заметное для конечного пользователя изменение? какой именно редирект у него не работал?

да, заметное... не работал редирект с эндпоинта кластера (сторадж нод) на ноды базы, как следствие, получалось разное поведение (например не было видно часть системных таблиц)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Договорились изменить на "Fixed redirects from cluster endpoints (storage nodes) to database nodes, resolving inconsistent behavior where some system tables were not visible."

Copy link

github-actions bot commented Apr 10, 2025

2025-04-10 07:38:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for b0ae071 has started.
2025-04-10 07:38:39 UTC Artifacts will be uploaded here
2025-04-10 07:41:29 UTC ya make is running...
🟢 2025-04-10 07:41:35 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-10 07:41:41 UTC Build successful.

Copy link

github-actions bot commented Apr 10, 2025

2025-04-10 07:41:56 UTC Pre-commit check linux-x86_64-release-asan for b0ae071 has started.
2025-04-10 07:42:12 UTC Artifacts will be uploaded here
2025-04-10 07:44:28 UTC ya make is running...
🟢 2025-04-10 07:44:34 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-10 07:44:40 UTC Build successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants