chore: bump version #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schlagonia
reviewed
Jun 18, 2024
.gitmodules
Outdated
| branch = greater_than |
There was a problem hiding this comment.
can you change this back to master
There was a problem hiding this comment.
and update the periphery submodule as well
| @@ -2,7 +2,7 @@ | |||
| src = 'src' | |||
| out = 'out' | |||
| libs = ['lib'] | |||
| solc = "0.8.18" | |||
| solc = "0.8.23" | |||
There was a problem hiding this comment.
Can you just add a small comment to the Readme that says something like "Compiler defaults to 8.23 but it can be adjusted in the foundry toml"
Schlagonia
added a commit
that referenced
this pull request
Jul 25, 2024
* chore: remove old * forge install: tokenized-strategy-periphery 6ce8d29b1e107a89754dd9f17337582734989b4d * fix: remove version * forge install: tokenized-strategy v3.0.2-1 * fix: module versions * chore: bump version (#34) * chore: bump version bump to 0.8.23 * chore: update submodules * fix: greater than 18 * fix: redo requirements * feat: one more bump * fix: use console2 --------- Co-authored-by: Schlag <[email protected]> * feat: comment --------- Co-authored-by: dudesahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump to use latest >= tokenized strategy and periphery. set 0.8.23 (last shanghai compiler version) as default for now