build: dutch auction and factory #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schlagonia
force-pushed
the
auction_factory
branch
from
5e34531 to
094c5fa
Compare
fp-crypto
reviewed
Feb 16, 2024
Comment on lines
+82
to
+90
| /// @notice The amount to start the auction at. | ||
| uint256 public startingPrice; | ||
|
|
||
| /// @notice The time that each auction lasts. | ||
| uint256 public auctionLength; | ||
|
|
||
| /// @notice The minimum time to wait between auction 'kicks'. | ||
| uint256 public auctionCooldown; | ||
|
|
There was a problem hiding this comment.
Sad these aren't immutable
There was a problem hiding this comment.
we could do clones with immutables
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 19, 2024
fp-crypto
reviewed
Feb 21, 2024
fp-crypto
reviewed
Feb 21, 2024
| * @param _from The token that was being sold. | ||
| */ | ||
| function _disableAuction(address _from) internal virtual { | ||
| Auction(auction).disable(_from); |
There was a problem hiding this comment.
require auction != zero address?
There was a problem hiding this comment.
will revert during the auction.disable() call
0xkorin
approved these changes
Feb 22, 2024
fp-crypto
approved these changes
Feb 22, 2024
| @@ -137,10 +137,14 @@ contract Auction is Governance, ReentrancyGuard { | |||
| require(_auctionLength < _auctionCooldown, "cooldown"); | |||
| require(_startingPrice != 0, "starting price"); | |||
|
|
|||
| // Cannot have more than 18 decimals. | |||
0xkorin
reviewed
Feb 22, 2024
src/Auctions/Auction.sol
Outdated
| @@ -137,10 +137,14 @@ contract Auction is Governance, ReentrancyGuard { | |||
| require(_auctionLength < _auctionCooldown, "cooldown"); | |||
| require(_startingPrice != 0, "starting price"); | |||
|
|
|||
| // Cannot have more than 18 decimals. | |||
| uint256 decimals = ERC20(_want).decimals(); | |||
| require(decimals <= WAD, "unsupported decimals"); | |||
There was a problem hiding this comment.
this should be decimals <= 18, right? or alternatively WAD / 10 ** decimals > 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hackmd.io/3ag321JBSOi0ijq0HPDoNQ?view