fix: tf remove

[Schlagonia]

• set correct array to storage
• Allow setTradeFactory to take in address(0)

[mil0xeth]

lgtm

[tapired]

I don't think you need this if check at all. You can use directy:

_rewardTokensLocal[i] = _rewardTokensLocal[
                        _rewardTokensLocal.length - 1
                    ];

If the length is 3, and the "i" is 2 it will just do an unnecessary set to array[2] = array[2]

Is it more gas friendly that way?

[Schlagonia]

an if check is more gas efficient than setting variables in a memory array.

Would expect the majority of uses would also only have 1 reward token so the will likely stop alot of unnecessary memory work

[tapired]

To fix this issue we need to add:

if (_tf != address(0)) ITradeFactory(_tf).disable(_tokenFrom, _tokenTo);;

or even

if (_tf != address(0)) {
ERC20(_tokenFrom).safeApprove(_tf, 0);
ITradeFactory(_tf).disable(_tokenFrom, _tokenTo);
}

Would that be a problem for the other actions that the trade factory will be used for?

[Schlagonia]

added

[tapired]

LGTM