Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BaseAuctioneer #45

Merged
merged 14 commits into from
May 6, 2024
Merged

feat: BaseAuctioneer #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8664195
feat: auctioneer swapper
fp-crypto Apr 22, 2024
3253584
fix: receiver check
fp-crypto Apr 22, 2024
c8146e8
chore: remove receiver
fp-crypto Apr 22, 2024
4c7f67f
chore: constructor
fp-crypto Apr 22, 2024
daac603
chore: rename
fp-crypto Apr 23, 2024
af1fb9e
chore: storage layout
fp-crypto Apr 23, 2024
9d5ea20
chore: interface
fp-crypto Apr 23, 2024
6ded7c3
chore: prettier
fp-crypto Apr 23, 2024
9fd9d3b
chore: test BaseAuctioneer
fp-crypto Apr 23, 2024
29c54b1
chore: oops
fp-crypto Apr 23, 2024
bcab073
chore: prettier
fp-crypto Apr 23, 2024
9d3b69e
fix: comment
fp-crypto Apr 23, 2024
377a4e5
feat: prefix BaseAuctioneer members with auction
fp-crypto Apr 24, 2024
83ad151
feat: allow cooldown == auction length
fp-crypto May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Auctions/Auction.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
/// @notice Array of all the enabled auction for this contract.
bytes32[] public enabledAuctions;

constructor() Governance(msg.sender) {}

Check warning on line 115 in src/Auctions/Auction.sol

View workflow job for this annotation

GitHub Actions / solidity 

Code contains empty blocks

/**
* @notice Initializes the Auction contract with initial parameters.
Expand All @@ -134,7 +134,7 @@
require(auctionLength == 0, "initialized");
require(_want != address(0), "ZERO ADDRESS");
require(_auctionLength != 0, "length");
require(_auctionLength < _auctionCooldown, "cooldown");
require(_auctionLength <= _auctionCooldown, "cooldown");
require(_startingPrice != 0, "starting price");

// Cannot have more than 18 decimals.
Expand Down Expand Up @@ -631,7 +631,7 @@
}

/// @dev Implements the take of the auction.
function _take(

Check warning on line 634 in src/Auctions/Auction.sol

View workflow job for this annotation

GitHub Actions / solidity 

Function body contains 73 lines but allowed no more than 50 lines
bytes32 _auctionId,
uint256 _maxAmount,
address _receiver,
Expand Down
Loading
Loading