Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proper type checking for ez-a-sync functions #658

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

BobTheBuidler
Copy link
Collaborator

Related issue # (if applicable):

What I did:

added proper type checking to a few a_sync utils so mypy works correctly

How I did it:

How to verify it:

Checklist:

  • I have tested it locally and it works
  • I have included any relevant documentation for the repo maintainers
  • (If fixing a bug) I have added a test to the test suite to test for this particular bug

Adding a Network

If the purpose of your PR is to add support for a new network, please copy the checklist from here into this PR conversation, and use it to track your changes.

Copy link
Contributor

@0xBasically 0xBasically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xBasically 0xBasically merged commit cd65021 into master Nov 9, 2023
0 of 12 checks passed
@0xBasically 0xBasically deleted the a-sync-type-checking branch November 9, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants