feat: shuffle all apps

yearn · Sep 18, 2024 · 560c93f · 560c93f
1 parent d8464c1
commit 560c93f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/apps/common/components/CategorySection.tsx b/apps/common/components/CategorySection.tsx
@@ -10,10 +10,9 @@ type TAppSectionProps = {
 	title: string;
 	onExpandClick: () => void;
 	apps: TApp[];
-	shouldRandomize?: boolean;
 };
 
-export function CategorySection({title, onExpandClick, apps, shouldRandomize = false}: TAppSectionProps): ReactElement {
+export function CategorySection({title, onExpandClick, apps}: TAppSectionProps): ReactElement {
 	const [shuffledApps, set_shuffledApps] = useState<TApp[]>([]);
 
 	/**********************************************************************************************
@@ -23,9 +22,6 @@ export function CategorySection({title, onExpandClick, apps, shouldRandomize = f
 		if (apps.length < 1) {
 			return;
 		}
-		if (!shouldRandomize) {
-			return set_shuffledApps(apps);
-		}
 		set_shuffledApps(apps.toSorted(() => 0.5 - Math.random()));
 	});
 	return (

diff --git a/pages/home/[category].tsx b/pages/home/[category].tsx
@@ -16,16 +16,13 @@ export default function Index(props: {router: NextRouter}): ReactElement {
 	}, [props.router.asPath]);
 
 	/**********************************************************************************************
-	 ** On component mount we shuffle the array of Integration Apps to avoid any bias.
+	 ** On component mount we shuffle the array of Apps to avoid any bias.
 	 **********************************************************************************************/
 	useMountEffect(() => {
 		if (currentCatrgory.apps.length < 1) {
 			return;
 		}
-		if (currentCatrgory.categoryName === 'Integrations') {
-			set_shuffledApps(currentCatrgory.apps.toSorted(() => 0.5 - Math.random()));
-		}
-		set_shuffledApps(currentCatrgory.apps);
+		set_shuffledApps(currentCatrgory.apps.toSorted(() => 0.5 - Math.random()));
 	});
 
 	return (

diff --git a/pages/home/index.tsx b/pages/home/index.tsx
@@ -99,7 +99,6 @@ export default function Home(): ReactElement {
 						/>
 
 						<CategorySection
-							shouldRandomize={true}
 							title={'Integrations'}
 							onExpandClick={() => router.push('/home/integrations')}
 							apps={INTEGRATIONS_APPS}