feat: Remove the network selector #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karelianpie
force-pushed
the
issues/343
branch
from
0e36f50 to
c054389
Compare
Majorfi
reviewed
Oct 1, 2023
|
|
||
| const filterHoldingsCallback = useCallback((address: TAddress): boolean => { | ||
| balancesNonce; | ||
| const holding = balances?.[toAddress(address)]; | ||
|
|
||
| // [Optimism] Check if staked vaults have holdings | ||
| if (safeChainID === 10) { | ||
| if (chains.includes(10)) { |
There was a problem hiding this comment.
Does this make sense to have this condition if we "always" have opt?
There was a problem hiding this comment.
What do you mean that we will always have opt? It's only in chains array if the user selected it
| @@ -146,7 +148,7 @@ function Index(): ReactElement { | |||
| **********************************************************************************************/ | |||
| const curveVaults = useFilteredVaults(vaults, ({category}): boolean => category === 'Curve'); | |||
| const boostedVaults = useFilteredVaults(vaults, ({address}): boolean => { | |||
| if (safeChainID !== 10) { | |||
| if (chains.includes(10)) { | |||
There was a problem hiding this comment.
Does this make sense to have this condition if we "always" have opt?
There was a problem hiding this comment.
Same as #344 (comment)
Comment on lines
+23
to
+29
| export const ChainIconMap = new Map<number, ReactElement>([ | ||
| [1, <IconEtherumChain />], | ||
| [10, <IconOptimismChain />], | ||
| [250, <IconFantomChain />], | ||
| [8453, <IconBaseChain />], | ||
| [42161, <IconArbitrumChain />] | ||
| ]); |
There was a problem hiding this comment.
We should probably have a config file for the chains stuff with all the elements related to chains, wdyt?
There was a problem hiding this comment.
Sounds good, in the web-lib right?
karelianpie
force-pushed
the
issues/343
branch
from
ef2a9ea to
3a4385b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Close #343
Motivation and Context
Remove the network selector, so all vaults from all networks are in the same list.
Users won't need to change networks to see all vaults, vault list filtering rather than app-wise
How Has This Been Tested?
Locally
Screenshots (if appropriate):