Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Adjust outdated redirects #363

Merged
merged 3 commits into from
Sep 27, 2023
Merged

refactor: Adjust outdated redirects #363

merged 3 commits into from
Sep 27, 2023

Conversation

0xMirim
Copy link
Contributor

@0xMirim 0xMirim commented Sep 25, 2023 •
edited
Loading

Description

Some redirects point to out outdated urls, this PR adjusts those that are out of date.

Motivation and Context

Keep redirects updated

@0xMirim 0xMirim requested a review from Majorfi September 25, 2023 10:06
@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yearnfi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 9:04am

@0xMirim 0xMirim changed the title refactor: Remove outdated and unused redirects refactor: Adjust outdated redirects Sep 25, 2023
karelianpie
karelianpie previously approved these changes Sep 25, 2023
View reviewed changes
@0xMirim
Copy link
Contributor Author

0xMirim commented Sep 27, 2023

Just updated /snapshot redirect. Only remaining thing I wasn't sure about if is the first redirect is still valid or if we should remove it. Either way not a huge deal and we can probably just merge these changes as they are now.

@0xMirim 0xMirim requested a review from karelianpie September 27, 2023 09:06
karelianpie
karelianpie approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@karelianpie karelianpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Majorfi Majorfi merged commit d73a02a into main Sep 27, 2023
9 checks passed
@Majorfi Majorfi deleted the update-redirects branch September 27, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelianpie karelianpie karelianpie approved these changes

@Majorfi Majorfi Awaiting requested review from Majorfi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xMirim @karelianpie @Majorfi