feat: useMaxRedeem for some situations #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Majorfi
commented
Apr 24, 2024
Comment on lines
+32
to
+71
| function AmountWithOptionalTooltip(props: { | ||
| canOnlyWithdrawSome: boolean; | ||
| maxPossibleToWithdraw: TNormalizedBN; | ||
| tokenSymbol: string; | ||
| }): ReactElement { | ||
| if (props.canOnlyWithdrawSome) { | ||
| return ( | ||
| <div className={'flex flex-row items-center justify-between space-x-2'}> | ||
| <label | ||
| htmlFor={'fromAmount'} | ||
| className={'hidden text-base text-neutral-600 md:inline'}> | ||
| {'Amount'} | ||
| </label> | ||
| <span className={'tooltip'}> | ||
| <IconQuestion className={'hidden opacity-40 md:block'} /> | ||
| <span className={'tooltipLight top-full w-full pt-1'}> | ||
| <div | ||
| className={ | ||
| 'font-number mr-[-360px] max-w-sm border border-neutral-300 bg-neutral-100 p-1 px-2 text-center text-xxs text-neutral-900' | ||
| }> | ||
| <p className={'font-number whitespace-pre text-wrap text-left text-neutral-400 md:text-xs'}> | ||
| {`This Vault is not always totally liquid (don’t worry anon, funds are Safu).\n\nYou can currently withdraw up to ${formatAmount(props.maxPossibleToWithdraw.normalized, 6)} ${props.tokenSymbol}.\n\nLike the best things in life, liquidity comes and goes so feel free to check back later.`} | ||
| </p> | ||
| </div> | ||
| </span> | ||
| </span> | ||
| </div> | ||
| ); | ||
| } | ||
| return ( | ||
| <div> | ||
| <label | ||
| htmlFor={'fromAmount'} | ||
| className={'hidden text-base text-neutral-600 md:inline'}> | ||
| {'Amount'} | ||
| </label> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Display a little (?) with a message if the user can only withdraw part of it's vault deposit
Majorfi
commented
Apr 24, 2024
| @@ -213,7 +255,7 @@ export function VaultDetailsQuickActionsFrom(): ReactElement { | |||
| onChangeAmount( | |||
| isDepositing | |||
| ? maxDepositPossible(toAddress(actionParams?.selectedOptionFrom?.value)) | |||
| : userBalance | |||
| : maxWithdrawPossible().safeLimit | |||
There was a problem hiding this comment.
Instead of just the user's balance, we use the safeLimit (either user balance of maxRedeem with some security)
w84april
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use max redeem to determine the max amount a user can withdraw