Created an AllCaps format test (Issue #237) #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yegor256
reviewed
Apr 1, 2024
tests/steps/test-allcaps.sh
Outdated
| msg=$("${LOCAL}/steps/measure-file.sh" "${java}" "${temp}/m1") | ||
| set -x | ||
| all=$(find "${temp}" -name 'm1.*' -type f -exec basename {} \; | sort) | ||
| expected=52 |
There was a problem hiding this comment.
@MoromugHSE looks like a typo. The expected should be counted from all
|
@MoromugHSE the test looks good, but it will fail, I believe. We should fix the code, in order for this test to work. |
|
Well, nothing fails on my local machine now! Seems to be all great. |
|
Now that is kind of strange. I don't see anything I could've done to destroy those package upgrades... |
Testing jpeek NaNs.
…ail, yet it does.
|
@MoromugHSE there is an obvious error in the build: |
Repo update
|
@MoromugHSE thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created (and updated to use current number of available metrics) a test suggested by issue #237.