Started collecting repo descriptions (Issue #246) #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sustain the csv file structure.
yegor256
reviewed
Apr 1, 2024
steps/discover-repos.rb
Outdated
| @@ -87,7 +87,8 @@ | |||
| forks: i[:forks_count], | |||
| created_at: i[:created_at].iso8601, | |||
| size: i[:size], | |||
| open_issues_count: i[:open_issues_count] | |||
| open_issues_count: i[:open_issues_count], | |||
| description: "\"".concat(i[:description], "\"") | |||
There was a problem hiding this comment.
@MoromugHSE I think, just i[:description] will be enough, no need to do the contatenation
|
@MoromugHSE please, don't forget to update the test too, to make sure we test this new functionality |
…y test to count the number of columns in the resulting csv file.
|
|
|
@MoromugHSE thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated discover-repos.rb to also include the repo description as suggested in issue #246. Wrapped it in double-quote characters to sustain the csv file structure.
TODO: upgrade the description processing further to escape the double-quotes found inside.