For #939: Upgrade to Junit 5 #1015
Conversation
|
Job #1015 is now in scope, role is |
|
This pull request #1015 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @krzyk/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
|
@krzyk PLease take a look, 0crat assigned me my own PR |
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-api</artifactId> | ||
| <version>5.3.1</version> |
There was a problem hiding this comment.
@paulodamaso this should be a test scope
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-engine</artifactId> | ||
| <version>5.1.0</version> |
| junit4 tags. | ||
| --> | ||
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> |
There was a problem hiding this comment.
@paulodamaso you also need to upgrade surefire and failsafe to the newest versions, right now they are taken from jcabi-parent
| @@ -59,7 +59,7 @@ public void passesCorrectFilesWithNoExceptions() throws Exception { | |||
| * @throws Exception If something wrong happens inside | |||
| */ | |||
| @Ignore | |||
| @Test(expected = ValidationException.class) | |||
| @org.junit.Test(expected = ValidationException.class) | |||
There was a problem hiding this comment.
@paulodamaso this should be from jupiter
There was a problem hiding this comment.
@krzyk I've not changed all tags from Jnit 4, as it would take way more than 30 min. I've left those expected tags to be fixed later in the @todo
| @@ -59,7 +59,7 @@ public void passesCorrectFilesWithNoExceptions() throws Exception { | |||
| * @throws Exception If something wrong happens inside | |||
| */ | |||
| @Ignore | |||
| @Test(expected = ValidationException.class) | |||
| @org.junit.Test(expected = ValidationException.class) | |||
There was a problem hiding this comment.
@krzyk I've not changed all tags from Jnit 4, as it would take way more than 30 min. I've left those expected tags to be fixed later in the @todo
|
@paulodamaso OK, but the build fails now. |
|
@krzyk I'll take a look, thanks |
|
@krzyk Please take a look |
|
@rultor merge |
|
@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
The job #1015 is now out of scope |
|
@paulodamaso Here again - wrong assignment :) I have to mark it as bad. Ok? |
|
@ypshenychka Yeah, please, these self-assigned tasks are bothering me because they take space im my agenda |
|
@paulodamaso I believe ARC can reassign it manually. Or we don't have any other REVs here? |
|
@0crat quality bad |
|
Quality is low, no payment, see §31 |
|
@ypshenychka unfortunately there are no REVs her |
|
@ypshenychka The project doesn't have enough funds, can't make a payment |
|
Quality review completed: +8 point(s) just awarded to @ypshenychka/z |
For #939: Upgrade to Junit 5
@Testannotation with Junit5@Test@Ignoreannotation with Junit5@Disabled