#1041 implemented docker daemon host health check #1051

original-brownbear · 2016-03-11T18:18:22Z

#1041 is resolved by this.

Added script that needs to exit 0 on a working Rultor SSH host.
Added SuperAgent executing this script
Added Test describing the SuperAgent behavior
Added puzzle for integrating this with the existing SuperAgents

alex-palevsky · 2016-03-11T18:46:36Z

@original-brownbear Let me find a reviewer for this pull request, thanks for submitting it

alex-palevsky · 2016-03-11T18:53:54Z

@HDouss review this please

HDouss · 2016-03-12T16:50:26Z

src/main/java/com/rultor/agents/docker/DockerHealthCheck.java

+ *   as soon as DockerHealthCheck#execute throws and exception.
+ *   #1041 has the details on the motivation behind this agent.
+ */
+public final class DockerHealthCheck implements SuperAgent {


@original-brownbear This is nearly the same code as DockerExec. Let's add a puzzle to refactor this code (and the one on DockerExec, so that they wrap or extend the same SuperAgent.

@HDouss I'd rather not but you deserve an explanation :)

This DockerExec class actually should just be deleted right now ... It was an ill conceived fix for #906 ... Right now this class does exactly nothing because the bash script it calls has its logic commented out.
I'll delete this soon I promise :), no point though having anyone dry up dead code.

HDouss · 2016-03-12T16:50:48Z

@original-brownbear Please see one comment above.

original-brownbear · 2016-03-12T18:31:44Z

@HDouss addressed that comment, all clear good otherwise from your end ? :)

HDouss · 2016-03-12T18:49:30Z

@original-brownbear Thanks.

HDouss · 2016-03-12T18:49:37Z

@rultor merge.

rultor · 2016-03-12T18:49:56Z

@rultor merge.

@HDouss @original-brownbear Sorry, I accept such requests only from authorized commanders: @yegor256, @alex-palevsky, @caarlos0, @carlosmiranda, @darkled, @dmzaytsev, @ggajos, @HDouss, @krzyk, @longtimeago, @mkordas, @original-brownbear, @pinaf, @original-brownbear, @yegor256, @alex-palevsky Your Github login should be added to the list of "commanders" in .rultor.yml, as explained here

rultor · 2016-03-12T18:49:57Z

@rultor merge.

@HDouss I'm sorry, I don't understand you :( Check this page and try again please

original-brownbear · 2016-03-12T18:50:41Z

@rultor merge

original-brownbear · 2016-03-12T18:51:00Z

@HDouss thanks!, though I don't like Rultor's message above ... looking into it.

rultor · 2016-03-12T18:51:02Z

@rultor merge

@original-brownbear OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-03-12T18:57:09Z

@rultor merge

@original-brownbear Oops, I failed. You can see the full log here (spent 6min)

INFO: "reading src/jekyll/_layouts/default.html..."
INFO: "reading src/jekyll/_plugins/contents.rb..."
INFO: "reading src/jekyll/_plugins/jekyll-git-hash.rb..."
INFO: "reading src/jekyll/_posts/2014/jul/2014-07-07-index.md..."
INFO: "reading src/jekyll/_posts/2014/jul/2014-07-13-basics.md..."
INFO: "reading src/jekyll/_posts/2014/jul/2014-07-13-docker.md..."
INFO: "reading src/jekyll/_posts/2014/jul/2014-07-13-privacy.md..."
INFO: "reading src/jekyll/_posts/2014/jul/2014-07-13-reference.md..."
INFO: "reading src/jekyll/_posts/2014/jul/2014-07-13-terms.md..."
INFO: "reading src/jekyll/_posts/2014/jul/2014-07-14-commands.md..."
INFO: "reading src/jekyll/contents.html..."
INFO: "reading src/jekyll/css/layout.scss..."
INFO: "reading src/jekyll/maintenance.html..."
INFO: "reading src/jekyll/robots.txt..."
INFO: "reading src/main/aspect/README.txt..."
INFO: "reading src/main/java/com/rultor/Entry.java..."
INFO: "reading src/main/java/com/rultor/Routine.java..."
INFO: "reading src/main/java/com/rultor/Time.java..."
INFO: "reading src/main/java/com/rultor/Toggles.java..."
INFO: "reading src/main/java/com/rultor/agents/AbstractAgent.java..."
INFO: "reading src/main/java/com/rultor/agents/Agents.java..."
INFO: "reading src/main/java/com/rultor/agents/DeactivatesTalks.java..."
INFO: "reading src/main/java/com/rultor/agents/IndexesRequests.java..."
INFO: "reading src/main/java/com/rultor/agents/Mails.java..."
INFO: "puzzle 748-9cbe7474 0/IMP at src/main/java/com/rultor/agents/Mails.java"
INFO: "puzzle 748-bb1cb5c5 0/IMP at src/main/java/com/rultor/agents/Mails.java"
INFO: "reading src/main/java/com/rultor/agents/Publishes.java..."
INFO: "reading src/main/java/com/rultor/agents/SafeAgent.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/ArchivesDaemon.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/EndsDaemon.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/Home.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/KillsDaemon.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/SanitizesDaemon.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/Script.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/ShellCommand.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/StartsDaemon.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/StopsDaemon.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/Tail.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/WipesDaemon.java..."
INFO: "reading src/main/java/com/rultor/agents/daemons/package-info.java..."
INFO: "reading src/main/java/com/rultor/agents/docker/DockerExec.java..."
INFO: "reading src/main/java/com/rultor/agents/docker/DockerHealthCheck.java..."
/var/lib/gems/2.2.0/gems/pdd-0.15.4/lib/pdd/source.rb:144:in `rescue in puzzles': ["in /home/r/repo/src/main/java/com/rultor/agents/docker/DockerHealthCheck.java", #<PDD::Error: Too many spaces>] (PDD::Error)
    from /var/lib/gems/2.2.0/gems/pdd-0.15.4/lib/pdd/source.rb:142:in `puzzles'
    from /var/lib/gems/2.2.0/gems/pdd-0.15.4/lib/pdd.rb:97:in `block (3 levels) in xml'
    from /var/lib/gems/2.2.0/gems/pdd-0.15.4/lib/pdd.rb:96:in `each'
    from /var/lib/gems/2.2.0/gems/pdd-0.15.4/lib/pdd.rb:96:in `block (2 levels) in xml'
    from /var/lib/gems/2.2.0/gems/nokogiri-1.6.7.1/lib/nokogiri/xml/builder.rb:391:in `call'
    from /var/lib/gems/2.2.0/gems/nokogiri-1.6.7.1/lib/nokogiri/xml/builder.rb:391:in `insert'
    from /var/lib/gems/2.2.0/gems/nokogiri-1.6.7.1/lib/nokogiri/xml/builder.rb:375:in `method_missing'
    from /var/lib/gems/2.2.0/gems/pdd-0.15.4/lib/pdd.rb:95:in `block in xml'
    from /var/lib/gems/2.2.0/gems/nokogiri-1.6.7.1/lib/nokogiri/xml/builder.rb:293:in `initialize'
    from /var/lib/gems/2.2.0/gems/pdd-0.15.4/lib/pdd.rb:93:in `new'
    from /var/lib/gems/2.2.0/gems/pdd-0.15.4/lib/pdd.rb:93:in `xml'
    from /var/lib/gems/2.2.0/gems/pdd-0.15.4/bin/pdd:90:in `<top (required)>'
    from /usr/local/bin/pdd:23:in `load'
    from /usr/local/bin/pdd:23:in `<main>'
container e1df9eebb87bd91471a8e1a7c1b02a2855cbe9725916b310d4d1bb405c23f83f is dead
Sat Mar 12 18:57:04 UTC 2016

original-brownbear · 2016-03-12T19:00:17Z

@rultor merge.

rultor · 2016-03-12T19:01:23Z

@rultor merge.

@original-brownbear OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-03-12T19:11:54Z

@rultor merge.

@original-brownbear Done! FYI, the full log is here (took me 10min)

alex-palevsky · 2016-03-14T13:17:39Z

@HDouss Thanks so much! Your account was topped up for 15 mins (transaction ID is 80118920, the task took 41 hours and 15 mins)

+15 to your rating, your total score is +3916

alex-palevsky · 2016-03-14T13:19:24Z

@rultor deploy

rultor · 2016-03-14T13:19:51Z

@rultor deploy

@alex-palevsky OK, I'll try to deploy now. You can check the progress here

rultor · 2016-03-14T13:29:52Z

@rultor deploy

@alex-palevsky Done! FYI, the full log is here (took me 10min)

original-brownbear force-pushed the 1041 branch from 4957dd0 to b5e370a Compare March 11, 2016 18:19

original-brownbear mentioned this pull request Mar 11, 2016

Cannot connect to the Docker daemon #1041

Closed

alex-palevsky added CR labels Mar 11, 2016

HDouss reviewed Mar 12, 2016
View reviewed changes

original-brownbear and others added 2 commits March 12, 2016 19:58

yegor256#1041 implemented docker daemon host health check

b372314

yegor256#1041 fixed puzzle indention

c49a17d

original-brownbear force-pushed the 1041 branch from b5e370a to c49a17d Compare March 12, 2016 18:59

rultor merged commit c49a17d into yegor256:master Mar 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1041 implemented docker daemon host health check #1051

#1041 implemented docker daemon host health check #1051

original-brownbear commented Mar 11, 2016

alex-palevsky commented Mar 11, 2016

alex-palevsky commented Mar 11, 2016

HDouss Mar 12, 2016

original-brownbear Mar 12, 2016

HDouss commented Mar 12, 2016

original-brownbear commented Mar 12, 2016

HDouss commented Mar 12, 2016

HDouss commented Mar 12, 2016

rultor commented Mar 12, 2016

rultor commented Mar 12, 2016

original-brownbear commented Mar 12, 2016

original-brownbear commented Mar 12, 2016

rultor commented Mar 12, 2016

rultor commented Mar 12, 2016

original-brownbear commented Mar 12, 2016

rultor commented Mar 12, 2016

rultor commented Mar 12, 2016

alex-palevsky commented Mar 14, 2016

alex-palevsky commented Mar 14, 2016

rultor commented Mar 14, 2016

rultor commented Mar 14, 2016

#1041 implemented docker daemon host health check #1051

#1041 implemented docker daemon host health check #1051

Conversation

original-brownbear commented Mar 11, 2016

alex-palevsky commented Mar 11, 2016

alex-palevsky commented Mar 11, 2016

HDouss Mar 12, 2016

Choose a reason for hiding this comment

original-brownbear Mar 12, 2016

Choose a reason for hiding this comment

HDouss commented Mar 12, 2016

original-brownbear commented Mar 12, 2016

HDouss commented Mar 12, 2016

HDouss commented Mar 12, 2016

rultor commented Mar 12, 2016

rultor commented Mar 12, 2016

original-brownbear commented Mar 12, 2016

original-brownbear commented Mar 12, 2016

rultor commented Mar 12, 2016

rultor commented Mar 12, 2016

original-brownbear commented Mar 12, 2016

rultor commented Mar 12, 2016

rultor commented Mar 12, 2016

alex-palevsky commented Mar 14, 2016

alex-palevsky commented Mar 14, 2016

rultor commented Mar 14, 2016

rultor commented Mar 14, 2016