Rate limit return #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated client with methods to return the rate limit after a request while keeping the original methods
- Added logic to stop retrieval in do-while loops if the rate limit was hit and the user chooses to obey rate limiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Client class so all methods support returning the remaining requests before being rate limited.
Also added a switch, timeout and tolerance to allow multi retrievals to delay themselves when the remaining requests drop below the user defined tolerance.
The change will be invisible to existing users as the original methods were left intact, they call the new rate limit returning methods and discard the rate limit. By default the "ObeyRateLimit" switch is set to false so the original handling of the batch retrieval methods remain intact.