Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve user fee bumps #1571

Open
uri-99 opened this issue Dec 4, 2024 · 0 comments · May be fixed by #1576
Open

refactor: improve user fee bumps #1571

uri-99 opened this issue Dec 4, 2024 · 0 comments · May be fixed by #1576
Assignees

Comments

@uri-99
Copy link
Contributor

uri-99 commented Dec 4, 2024

The idea is to refactor the bumping mechanism, when a user wants to bump the fee for a proof.

For this in the SDK there should be a function that takes either:

  • % to bump
  • amount to bump
  • new max fee (current implementation
  • bump to match a batch of size N

This functions should also be callable via the aligned CLI.

After this bump mechanism is working, the previous bumping mechanism should be deprecated, the mechanism of replacement messages; Replacing a same nonce with a highest fee brings all sorts of problems, from the WS connection, to the known limits to max_fee, and the need for the user to know the nonces he sent (which he never does).

@uri-99 uri-99 self-assigned this Dec 4, 2024
@uri-99 uri-99 linked a pull request Dec 4, 2024 that will close this issue
17 tasks
@uri-99 uri-99 linked a pull request Dec 4, 2024 that will close this issue
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant