refactor: improve user fee bumps #1576
Conversation
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
| ClientMessage::BumpFee(bump_unit, amout, proof_qty) => { | ||
| self.clone() | ||
| .handle_bump_fee_msg(bump_unit, amout, proof_qty, ws_conn_sink) | ||
| .await | ||
| } |
There was a problem hiding this comment.
I think it would make sense for the unit conversion to happen in the SDK so the batcher can handle just wei. This makes for faster feedback on invalid units (the SDK doesn't need to wait for the batcher to respond to know it was the wrong unit), reduces attack surface for the batcher and makes for fewer things to check.
I'm not 100% sure this covers the batch size and percentual cases OTOH.
There was a problem hiding this comment.
It would also be more flexible for the user programs that could use different strategies for increasing proposed fees.
| @@ -396,6 +400,86 @@ pub enum GetNonceResponseMessage { | |||
| InvalidRequest(String), | |||
| } | |||
|
|
|||
| pub struct BumpFeeMessage { | |||
| pub conent: BumpFeeMessageContent, | |||
There was a problem hiding this comment.
Typo:
| pub conent: BumpFeeMessageContent, | |
| pub content: BumpFeeMessageContent, |
| pub fn new(bump_unit: BumpUnit, value: U256, proof_qty: usize) -> Self { | ||
| let now = SystemTime::now() | ||
| .duration_since(UNIX_EPOCH) | ||
| .expect("Time went backwards"); |
There was a problem hiding this comment.
This is actually possible (for how computers process time, not in the physical reality), so I don't recommend crashing. Returning an error if it would be incorrect wouldn't be bad tho.
There was a problem hiding this comment.
That said, if it went back to before UNIX_EPOCH the user has a misconfigured machine, or hit 2038 without updating.
Improve user fee bumps
Description
This PR aims to improve the fee bumping process for a user and his proofs.
More details on this PR's issue
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging