Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(contracts): Add script + guide to set aggregator address #1487

Merged
merged 24 commits into from
Dec 6, 2024

Conversation

PatStiles
Copy link
Contributor

Add script + guide to set aggregator address

Description

Adds script and guide to set the aggregator address of the AlignedServiceManager.sol contract

To Test

  • Start local anvil node.
make anvil_start_with_block_time
```bash
- Check the current value of `alignedAggregator` within the AlignedServiceManager.sol contract.
```bash
cast call 0x851356ae760d987E095750cCeb3bC6014560891C "alignedAggregator()(address)"
  • Set the value of alignedAggregator using the script.
export AGGREGATOR_ADDRESS=0x0000000000000000000000000000000000000001
make set_aggregator_address_devnet
  • Verify alignedAggregator has been changed to 0x0000000000000000000000000000000000000001 within the AlignedServiceManager.sol contract.
cast call 0x851356ae760d987E095750cCeb3bC6014560891C "alignedAggregator()(address)"

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@PatStiles PatStiles changed the base branch from testnet to staging November 25, 2024 20:10
Copy link
Collaborator

@JulianVentura JulianVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine locally, left you some suggestions

@PatStiles PatStiles force-pushed the feat/set_aggregator_address_script branch from 365f27b to ce34fd0 Compare November 27, 2024 13:05
Copy link
Collaborator

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nit comments. Otherwise, LGTM!

@PatStiles PatStiles self-assigned this Nov 27, 2024
@avilagaston9 avilagaston9 force-pushed the feat/set_aggregator_address_script branch from 643108c to eb28688 Compare November 29, 2024 19:49
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Copy link
Collaborator

@JulianVentura JulianVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected. Great work!

@JuArce JuArce enabled auto-merge December 6, 2024 15:24
@JuArce JuArce added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@MarcosNicolau MarcosNicolau added this pull request to the merge queue Dec 6, 2024
Merged via the queue into staging with commit 7a15d39 Dec 6, 2024
3 checks passed
@MarcosNicolau MarcosNicolau deleted the feat/set_aggregator_address_script branch December 6, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants