-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(contracts): Add script + guide to set aggregator address #1487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked fine locally, left you some suggestions
365f27b
to
ce34fd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nit comments. Otherwise, LGTM!
Co-authored-by: Julian Ventura <[email protected]>
643108c
to
eb28688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked as expected. Great work!
Add script + guide to set aggregator address
Description
Adds script and guide to set the aggregator address of the AlignedServiceManager.sol contract
To Test
alignedAggregator
using the script.export AGGREGATOR_ADDRESS=0x0000000000000000000000000000000000000001 make set_aggregator_address_devnet
alignedAggregator
has been changed to0x0000000000000000000000000000000000000001
within the AlignedServiceManager.sol contract.cast call 0x851356ae760d987E095750cCeb3bC6014560891C "alignedAggregator()(address)"
Type of change
Please delete options that are not relevant.
Checklist
testnet
, everything else tostaging