Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make targets to modify strategies #1530

Merged
merged 14 commits into from
Jan 9, 2025
Merged

feat: make targets to modify strategies #1530

merged 14 commits into from
Jan 9, 2025

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Nov 29, 2024

Make targets to read and modify strategy weights

Description

This functionality is needed since strategy weights change over time

Type of change

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

avilagaston9
avilagaston9 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JuArce JuArce changed the title 1527 feat make targets to modify strategies feat: make targets to modify strategies Dec 2, 2024
@uri-99 uri-99 self-assigned this Dec 3, 2024
@uri-99 uri-99 requested a review from PatStiles December 4, 2024 15:22
JuArce
JuArce requested changes Dec 10, 2024
View reviewed changes
docs/0_internal/6_b_1_propose_modify_strategies.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@JuArce JuArce added this pull request to the merge queue Jan 9, 2025
Merged via the queue into staging with commit 4f63510 Jan 9, 2025
3 checks passed
@JuArce JuArce deleted the 1527-feat-make-targets-to-modify-strategies branch January 9, 2025 15:31
PatStiles added a commit that referenced this pull request Jan 9, 2025
@uri-99 @PatStiles @avilagaston9
feat: make targets to modify strategies (#1530)
528040d 
Co-authored-by: PatStiles <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
PatStiles added a commit that referenced this pull request Jan 9, 2025
@uri-99 @PatStiles @avilagaston9
feat: make targets to modify strategies (#1530)
0b0c9dd 
Co-authored-by: PatStiles <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
PatStiles added a commit that referenced this pull request Jan 10, 2025
@uri-99 @PatStiles @avilagaston9
feat: make targets to modify strategies (#1530)
454acdb 
Co-authored-by: PatStiles <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
PatStiles added a commit that referenced this pull request Jan 10, 2025
@uri-99 @PatStiles @avilagaston9
feat: make targets to modify strategies (#1530)
29e296c 
Co-authored-by: PatStiles <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avilagaston9 avilagaston9 avilagaston9 approved these changes

@JuArce JuArce JuArce approved these changes

@PatStiles PatStiles PatStiles approved these changes

Assignees

@uri-99 uri-99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uri-99 @PatStiles @JuArce @avilagaston9