Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): deprecate batcher_url parameter #1568

Open
wants to merge 18 commits into
base: staging
Choose a base branch
from
Open

feat(sdk): deprecate batcher_url parameter #1568

wants to merge 18 commits into from

Conversation

PatStiles
Copy link
Contributor

SDK Changes

Description

Makes some changes to sdk:

  • Derives batcher_url from Network paramater.
  • Adds --private_key flag to DepositToBatcher
  • Adds msg to batcher errors telling a user there funds have not been spent.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

uri-99
uri-99 reviewed Dec 4, 2024
View reviewed changes
batcher/aligned/src/main.rs Outdated Show resolved Hide resolved
uri-99
uri-99 reviewed Dec 4, 2024
View reviewed changes
batcher/aligned/src/main.rs Outdated Show resolved Hide resolved
uri-99
uri-99 reviewed Dec 4, 2024
View reviewed changes
batcher/aligned/src/main.rs Outdated Show resolved Hide resolved
uri-99
uri-99 reviewed Dec 4, 2024
View reviewed changes
batcher/aligned/src/main.rs Outdated Show resolved Hide resolved
uri-99
uri-99 reviewed Dec 4, 2024
View reviewed changes
batcher/aligned/src/main.rs Outdated Show resolved Hide resolved
uri-99
uri-99 requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@MarcosNicolau
Copy link
Collaborator

@uri-99, your comments have been addressed at: 2e8465c.

@uri-99 uri-99 changed the title feat(sdk): SDK changes feat(sdk): deprecata batcher_url parameter Dec 5, 2024
@MarcosNicolau MarcosNicolau changed the title feat(sdk): deprecata batcher_url parameter feat(sdk): deprecate batcher_url parameter Dec 5, 2024
@MarcosNicolau MarcosNicolau requested a review from uri-99 December 5, 2024 19:32
uri-99
uri-99 requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing remove batcher-url from rust task sender.

@MarcosNicolau MarcosNicolau requested a review from uri-99 December 5, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosNicolau MarcosNicolau MarcosNicolau left review comments

@uri-99 uri-99 uri-99 approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees

@PatStiles PatStiles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatStiles @MarcosNicolau @uri-99