Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Price Estimates in Aligned CLI #1577

Merged
merged 80 commits into from
Jan 20, 2025
Merged

feat(cli): Price Estimates in Aligned CLI #1577

Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
c857a56
add price estimate as submission fee mechanism
PatStiles Dec 4, 2024
6040beb
rm error
PatStiles Dec 4, 2024
2e17db3
fmt
PatStiles Dec 4, 2024
4811db3
change name per cmts in #1558
PatStiles Dec 4, 2024
9e19acb
comment nit
PatStiles Dec 5, 2024
7c2d8f9
remove unneeded println
PatStiles Dec 5, 2024
d9c6b65
help section for cli command + prompt correct usage in errors
PatStiles Dec 5, 2024
b1c1f19
update doc comment
PatStiles Dec 5, 2024
ad91ac6
return error if user specifies both fee arguments are specified
PatStiles Dec 5, 2024
5f9d344
print max_fee in ethers
PatStiles Dec 5, 2024
c2742ff
doc changes
PatStiles Dec 5, 2024
233004f
adjust fee estime with respect to gas percentage bump in batcher + fmt
PatStiles Dec 5, 2024
dccfbbf
max_fee => max_fee_wei
PatStiles Dec 5, 2024
196056b
nit: types.rs network -> price estimate
PatStiles Dec 5, 2024
d0a99e0
use mutual exclusive args + fmting + fmt
PatStiles Dec 5, 2024
33b1044
remove unneeded TryFrom
PatStiles Dec 5, 2024
8cae2c9
cmt nits
PatStiles Dec 5, 2024
4e23678
make cases explicit instead of fun
PatStiles Dec 6, 2024
c481a00
Merge branch 'staging' into feat/sdk-pricing
PatStiles Dec 6, 2024
ac8e5b3
clippy
PatStiles Dec 6, 2024
620384b
docs + cmts + made function name more specific
PatStiles Dec 6, 2024
dcd00a1
clippy
PatStiles Dec 6, 2024
4482459
marcos comments
PatStiles Dec 6, 2024
4ffab99
marcos comments
PatStiles Dec 6, 2024
ff5ff80
fmt
PatStiles Dec 6, 2024
430b989
address Uri's comments + clippy + fmt
PatStiles Dec 6, 2024
61ab98c
nit
PatStiles Dec 6, 2024
e03f75a
missing name change
PatStiles Dec 6, 2024
170f3a3
gaston's comments
PatStiles Dec 6, 2024
f8d8308
naming nit
PatStiles Dec 6, 2024
ad111db
can variable names for price in DepositToBatcher that got mixed in me…
PatStiles Dec 6, 2024
13efe4d
change to 10
PatStiles Dec 9, 2024
d1e4c9e
uri's comments + nits + naming changes
PatStiles Dec 9, 2024
590c7d5
add back tests
PatStiles Dec 9, 2024
543c055
clippy
PatStiles Dec 9, 2024
5471636
fmt
PatStiles Dec 9, 2024
495787a
fix tests
PatStiles Dec 10, 2024
17c3ba8
feat: better msg
uri-99 Dec 10, 2024
252f8a6
revert constant as per Mauro's request
PatStiles Jan 7, 2025
caf344b
chore: cargo fmt
uri-99 Jan 7, 2025
bf8bdb1
gaston's comments
PatStiles Jan 8, 2025
24c7840
Merge branch 'staging' into feat/sdk-pricing
uri-99 Jan 9, 2025
23ec4be
fix: error types and comment
uri-99 Jan 9, 2025
cdadb70
docs: add to CLI docs, and better --help info
uri-99 Jan 9, 2025
6921c5e
chore: cargo fmt
uri-99 Jan 9, 2025
d55f58e
remove NetworkArg type
PatStiles Dec 10, 2024
bd1139b
add lock
PatStiles Dec 10, 2024
bab051a
pass by copy
PatStiles Jan 2, 2025
8c4049a
remove need for ValueEnum
PatStiles Jan 7, 2025
a289328
fmt + clippy
PatStiles Jan 7, 2025
82fa721
move values to constants
PatStiles Jan 8, 2025
510f6e2
add custom network arg
PatStiles Jan 8, 2025
9b2d37b
fmt
PatStiles Jan 8, 2025
a320ab0
change error messages
PatStiles Jan 8, 2025
587a5fa
enforce custom in right place + fix
PatStiles Jan 10, 2025
1a4ef29
remove clap from cargo.toml
PatStiles Jan 9, 2025
0ac4db3
deprecate batcher_url
PatStiles Jan 10, 2025
c765ecf
deprecate more
PatStiles Jan 10, 2025
2f6da7c
feat: better implementation of this pr
uri-99 Jan 15, 2025
0dab9a1
Merge branch 'staging' into feat/deprecate-batcher-url
uri-99 Jan 16, 2025
ec9685d
chore: cargo fmt
uri-99 Jan 16, 2025
9da8dcc
feat: migrate rust task sender
uri-99 Jan 16, 2025
5873fa4
chore: docs
uri-99 Jan 16, 2025
ceafba5
chore: cargo fmt
uri-99 Jan 16, 2025
ab87086
chore: cargo clippy
uri-99 Jan 16, 2025
51f576a
chore: add error failure on CI
uri-99 Jan 17, 2025
79a3b8a
chore: fix comment
uri-99 Jan 17, 2025
d7dc1c1
fix: debugging error in CI
uri-99 Jan 17, 2025
ce35d41
fix(wip): print .json contents
uri-99 Jan 17, 2025
f05869e
fix: prints
uri-99 Jan 17, 2025
1c3b245
fix: revert CI changes, they are in another pr
uri-99 Jan 17, 2025
8e582ca
Merge branch 'pull_fixes_testnet_17_01' into feat/deprecate-batcher-url
uri-99 Jan 17, 2025
5d32849
fix: docs
uri-99 Jan 17, 2025
5447237
chore: cargo fmt
uri-99 Jan 17, 2025
00a252c
fix: batcher urls
JuArce Jan 17, 2025
cc84f6e
fix: missing new line
JuArce Jan 17, 2025
4e05916
Merge branch 'feat/deprecate-batcher-url' into feat/sdk-pricing
uri-99 Jan 17, 2025
beef3cf
chore: cargo fmt
uri-99 Jan 17, 2025
2176004
Merge branch 'staging' into feat/sdk-pricing
uri-99 Jan 20, 2025
aca5e7d
fix: comment
JuArce Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading