Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk): Remove NetworkArg + Make functions that accept Network methods of Network #1598

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

PatStiles
Copy link
Contributor

Refactor Network Arg

Description

Refactors the Network struct in the sdk to:

  • Derive ValueEnum and thus remove the need for NetworkArg
  • Refactors functions that accept Network and return addresses to be methods of Network.

Type of change

Please delete options that are not relevant.

  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@PatStiles PatStiles changed the title refactor(sdk): Remove NetworkArg + Make get_<Address> functions methods of Network refactor(sdk): Remove NetworkArg + Make functions that accept Network methods of Network Dec 10, 2024
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants