Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: telemetry script to rewrite operator names #1600

Open
wants to merge 3 commits into
base: testnet
Choose a base branch
from

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Dec 10, 2024

Telemetry script to rewrite operator names

Description

This is a script that was made to rewrite the operator names in mainnet. This was already executed and the content of the scipt worked, tho the context of how to executed was a bit different to execute in mainnet server.

This was needed because during mainnet deploy, there was a hotfix that hardcoded the names of operators. Now we wanted the actual names to be stored

This script was already executed succesfully

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 linked an issue Dec 10, 2024 that may be closed by this pull request
@uri-99 uri-99 marked this pull request as ready for review December 10, 2024 14:58
@uri-99 uri-99 force-pushed the 1595-hotfixtelemetry-script-to-rewrite-operator-names branch from c0c22a5 to 848248d Compare December 10, 2024 18:36
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing instructions on how to use

Comment on lines +14 to +17
echo "You will now connect to the Telemetry Node, make sure you run the following command inside it:"
echo "Scripts.FetchOperatorsMetadata.run()"

iex --sname fetch_operators_metadata --remsh telemetry@$ELIXIR_HOSTNAME
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could just echo the command?

echo "Scripts.FetchOperatorsMetadata.run()" | iex --sname fetch_operators_metadata --remsh telemetry@$ELIXIR_HOSTNAME

Am I missing something that makes that not work?

Copy link
Collaborator

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uri-99 uri-99 requested a review from JuArce January 16, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hotfix(telemetry): script to rewrite operator names
4 participants