Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade testcafe to remove dependency vuln #1193

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

Fondryext
Copy link
Contributor

Upgrade testcafe from 1.18.6 to 3.6.1. In the process, this removes the dependency on jsonwebtoken, which had a vuln in the version we were using.
https://nvd.nist.gov/vuln/detail/CVE-2022-23539#vulnCurrentDescriptionTitle
J=VULN-39102
TEST=auto

Upgrade testcafe from 1.18.6 to 3.6.1. In the process, this removes the dependency on jsonwebtoken, which had a vuln in the version we were using.
https://nvd.nist.gov/vuln/detail/CVE-2022-23539#vulnCurrentDescriptionTitle
J=VULN-39102
TEST=auto
@Fondryext Fondryext requested a review from a team as a code owner June 27, 2024 20:54
@coveralls
Copy link

Coverage Status

coverage: 9.074%. remained the same
when pulling 1aff7e6 on dev/v1.34.1
into d6827d7 on hotfix/v1.34.1.

@Fondryext
Copy link
Contributor Author

Note: WCAG failures occur on master as well.

Copy link
Contributor

@vijay267 vijay267 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fondryext Fondryext merged commit deef9d8 into hotfix/v1.34.1 Jul 5, 2024
13 of 15 checks passed
@Fondryext Fondryext deleted the dev/v1.34.1 branch July 5, 2024 17:05
@Fondryext Fondryext restored the dev/v1.34.1 branch July 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants