add type: module or type: commonjs to package.json #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbramblett
approved these changes
Aug 30, 2023
yen-tt
added a commit
that referenced
this pull request
Aug 30, 2023
bump version for this update: #36 J=CLIP-450 TEST=manual see that test-site is still ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds
type: moduleortype: commonjsto package.json.Also updated test-site to resolve the issue from adding this
typefield. see this PR for more details: yext/chat-ui-react#37J=CLIP-450
TEST=manual
see that the type field is in lib/esm and lib/commonjs for chat-headless and chat-headless-react. See that test-site still works as expected.
