Add support for static response data in mock Slack server #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmr
force-pushed
the
additional-apis
branch
3 times, most recently
from
3af45d1 to
450fffa
Compare
|
@gmr Thanks for the contribution. Just a minor request, can you please squash the commits yourself so that you keep some of them separate if you see fit |
Move request validation to `prepare()` method, ensuring all requests are validated upfront. This eliminates redundant validation checks in `post()` methods and simplifies handler logic. Signed-off-by: Gavin M. Roy <[email protected]> Refactor logging to use `logging` module instead of `print` Updated all modules to replace `print` statements with appropriate logging using the `logging` module. Introduced global loggers and added configurations to improve consistency and maintainability of log messages. Signed-off-by: Gavin M. Roy <[email protected]>
Introduced a framework for serving static mock responses for specific Slack API endpoints using JSON files. Updated server infrastructure, handlers, and settings configuration to support this functionality, including `response_data_path` and appropriate endpoint routing. Enhanced the documentation with details on configuring and structuring response data. Signed-off-by: Gavin M. Roy <[email protected]>
|
I took a look at why the tests are failing. The reason is that it is executed as a block-box container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a framework for serving static mock responses for specific Slack API endpoints using JSON files. Updated server infrastructure, handlers, and settings configuration to support this functionality, including
response_data_pathand appropriate endpoint routing. Enhanced the documentation with details on configuring and structuring response data.This allowed me to easily add in endpoints for
conversations.history,conversations.info,conversations.replies, andusers.infowhich I needed for my testing.In addition, I refactored a little to use logging instead of print statements, as it would have been helpful to debug my initial issues in getting up and running.
Finally I removed a little bit of duplicate Tornado RequestHandler code by moving request validation to
prepare()method, ensuring all requests are validated upfront. This eliminates redundant validation checks inget()andpost()methods and simplifies handler logic.Let me know if you'd like to see any changes.