Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ColumnDefinitionBuilder #330

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 17, 2024

Rellated PR

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.64%. Comparing base (154c05c) to head (60fa5f3).

Files with missing lines Patch % Lines
src/Column/ColumnDefinitionBuilder.php 71.42% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #330      +/-   ##
============================================
- Coverage     98.21%   97.64%   -0.57%     
- Complexity      216      220       +4     
============================================
  Files            20       20              
  Lines           673      680       +7     
============================================
+ Hits            661      664       +3     
- Misses           12       16       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 9e7ca32 into master Nov 17, 2024
2 checks passed
@Tigrov Tigrov deleted the refactor-column-definition-builder branch November 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants