Use new column definition builder #329
Open
+27
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
=========================================
Coverage 98.51% 98.51%
- Complexity 336 337 +1
=========================================
Files 23 23
Lines 1077 1079 +2
=========================================
+ Hits 1061 1063 +2
Misses 16 16 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Dec 6, 2024
| @@ -12,8 +12,7 @@ final class ColumnDefinitionBuilder extends AbstractColumnDefinitionBuilder | |||
| { | |||
| protected const AUTO_INCREMENT_KEYWORD = 'AUTOINCREMENT'; | |||
|
|
|||
| protected const GENERATE_UUID_EXPRESSION = | |||
| "(unhex(format('%016X', random() & 0xFFFFFFFFFFFF4FFF | 0x4000) || format('%016X', random() & 0xBFFFFFFFFFFFFFFF | 0xB000000000000000)))"; | |||
| protected const GENERATE_UUID_EXPRESSION = '(randomblob(16))'; | |||
|
|
|||
There was a problem hiding this comment.
Is that v4 or v7? V7 is much preferred.
There was a problem hiding this comment.
It is not valid v4.
The previous valid v4 requires to update sqlite extension for php (unhex() requires new version of sqlite).
samdark
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR