Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and deprecate Schema methods #801

Merged
merged 14 commits into from
Feb 10, 2024
Merged

Move and deprecate Schema methods #801

merged 14 commits into from
Feb 10, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 25, 2024

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a08ca3) 99.64% compared to head (e94a5fd) 99.55%.
Report is 1 commits behind head on master.

❗ Current head e94a5fd differs from pull request most recent head 7473f66. Consider uploading reports for the commit 7473f66 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #801      +/-   ##
============================================
- Coverage     99.64%   99.55%   -0.10%     
- Complexity     1270     1277       +7     
============================================
  Files            63       63              
  Lines          3106     3120      +14     
============================================
+ Hits           3095     3106      +11     
- Misses           11       14       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Helper/DbStringHelper.php Show resolved Hide resolved
src/Schema/SchemaInterface.php Show resolved Hide resolved
src/Schema/SchemaInterface.php Show resolved Hide resolved
src/Schema/SchemaInterface.php Show resolved Hide resolved
src/Schema/SchemaInterface.php Show resolved Hide resolved
Copy link

what-the-diff bot commented Jan 26, 2024

PR Summary

  • Deprecated methods
    Earlier in the software design, multiple methods have been phased out as they are now replaced with better functioning equivalents. The outdated methods include AbstractSchema::normalizeRowKeyCase(), SchemaInterface::getRawTableName(), SchemaInterface::isReadQuery(), DbStringHelper::baseName(), and DbStringHelper::isReadQuery().

  • Added methods to improve functionality
    New methods have been introduced to improve on the deficiencies of the deprecated ones. They are Quoter::getRawTableName(), DbStringHelper::isReadQuery(), and AbstractPdoConnection::setTablePrefix(). These methods bring with them enhanced functionality ensuring better, efficient results.

  • Method enhancements
    Certain existing methods have seen changes to improve their performance or to fix the potential problems they could encounter. Amendments have been made in the Quoter::getRawTableName(), Quoter::$tablePrefix, and AbstractConnection::$tablePrefix property has also been fixed to prevent any issues.

  • Simpler syntax
    A redundant symbol has been removed from the rtrim() function inside the DbStringHelper::baseName() method. This small change leads to simpler, cleaner code.

Please note, these above steps were taken to enhance our software by making it more efficient and simpler to use.

CHANGELOG.md Show resolved Hide resolved
src/Connection/AbstractConnection.php Outdated Show resolved Hide resolved
src/Connection/AbstractConnection.php Outdated Show resolved Hide resolved
@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 31, 2024
@Tigrov Tigrov requested a review from darkdef February 6, 2024 10:28
@Tigrov Tigrov merged commit e44b52f into master Feb 10, 2024
2 of 3 checks passed
@Tigrov Tigrov deleted the deprecate-schema-methods branch February 10, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants