-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New columns for v2 #808
New columns for v2 #808
Conversation
PR Summary
All these changes collectively aim to expand capabilities of database operations, making the system much more versatile. From running queries in a more effective way to handling a wide variety of column types, these updates bring greater flexibility and utility to the table. |
# Conflicts: # src/QueryBuilder/AbstractDDLQueryBuilder.php
# Conflicts: # src/QueryBuilder/AbstractDDLQueryBuilder.php
# Conflicts: # src/QueryBuilder/ColumnDefinitionBuilder.php # src/Schema/Column/BigIntColumn.php # src/Schema/Column/BinaryColumn.php # src/Schema/Column/BitColumn.php # src/Schema/Column/BooleanColumn.php # src/Schema/Column/Column.php # src/Schema/Column/ColumnBuilder.php # src/Schema/Column/ColumnBuilderInterface.php # src/Schema/Column/ColumnFactory.php # src/Schema/Column/ColumnFactoryInterface.php # src/Schema/Column/ColumnInterface.php # src/Schema/Column/DoubleColumn.php # src/Schema/Column/IntegerColumn.php # src/Schema/Column/StringColumn.php # src/Schema/SchemaInterface.php # tests/AbstractSchemaTest.php # tests/AbstractTableSchemaTest.php # tests/Db/Schema/ColumnSchemaTest.php # tests/Db/Schema/SchemaTest.php
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #808 +/- ##
=============================================
- Coverage 99.56% 80.92% -18.64%
- Complexity 1316 1466 +150
=============================================
Files 64 75 +11
Lines 3236 3686 +450
=============================================
- Hits 3222 2983 -239
- Misses 14 703 +689 ☔ View full report in Codecov by Sentry. |
This is a draft to see new concept of columns for version 2.0
Main changes:
ColumnSchema::$name
andColumnSchema::$precision
(useColumnSchema::$size
)ColumnSchema::$enumValues
toColumnSchema::$values
(related with some issues)ColumnSchema::getFullDbType()
method to get full name of the type, e.g.varchar(20)
pk
abstract type constantsColumnSchemaInterface::...pk
useColumnBuilder::...pk()
insteadAbstractColumn
andColumnInterface
marked as deprecated till version 3.0.0AbstractColumnSchema
renamed toColumn
TypeColumn
classes (IntegerColumn
,StringColumn
, etc)ColumnFactory
,ColumnBuilder
andColumnDefinitionBuilder
TableSchema
(instead ofAbstractSchema::resolveTableName()
)The changes will solve few issues and after related improvements it will solve few more issues.
It will allow specify any php type or object type for any db type or table column.