Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ColumnDefinitionBuilder #883

Merged
merged 18 commits into from
Oct 15, 2024
Merged

Add ColumnDefinitionBuilder #883

merged 18 commits into from
Oct 15, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 9, 2024 •
edited
Loading

Tigrov and others added 6 commits October 7, 2024 14:41
@Tigrov
Add ColumnDefinitionBuilder
04a4302
@Tigrov
Merge branch 'refs/heads/master' into column-definition-builder
6347c84 
# Conflicts:
#	src/Expression/StructuredExpression.php
#	src/Schema/Column/ArrayColumnSchema.php
#	src/Schema/Column/StructuredColumnSchema.php
#	tests/Db/Expression/StructuredExpressionTest.php
#	tests/Db/Schema/ColumnSchemaTest.php
#	tests/Provider/ColumnBuilderProvider.php
#	tests/Provider/StructuredTypeProvider.php
@Tigrov
Fix after merge
d120dcc
@StyleCIBot
Apply fixes from StyleCI
2e3b2c2
@Tigrov
Update
3b681c5
@Tigrov
Merge remote-tracking branch 'origin/column-definition-builder' into …
5c0ce4d 
…column-definition-builder

# Conflicts:
#	tests/Support/Stub/ColumnDefinitionBuilder.php
This was referenced Oct 9, 2024
Merged
Merged
Merged
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (b9c2ce9) to head (6d3bf21).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #883      +/-   ##
============================================
+ Coverage     99.56%   99.63%   +0.06%     
- Complexity     1485     1537      +52     
============================================
  Files            80       81       +1     
  Lines          3696     3809     +113     
============================================
+ Hits           3680     3795     +115     
+ Misses           16       14       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Oct 9, 2024
@Tigrov Tigrov requested a review from a team October 9, 2024 05:52
samdark
samdark approved these changes Oct 9, 2024
View reviewed changes
src/QueryBuilder/AbstractColumnDefinitionBuilder.php Outdated Show resolved Hide resolved
src/QueryBuilder/AbstractColumnDefinitionBuilder.php Outdated Show resolved Hide resolved
@Tigrov Tigrov merged commit 8abb33a into master Oct 15, 2024
3 checks passed
@Tigrov Tigrov deleted the column-definition-builder branch October 15, 2024 06:11
@Tigrov Tigrov mentioned this pull request Nov 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tigrov @samdark @StyleCIBot