Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ColumnSchemaInterface::load(), add properties to constructor #890

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 18, 2024

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.60%. Comparing base (ee6f00e) to head (b646fb7).

Files with missing lines Patch % Lines
src/Schema/Column/AbstractColumnFactory.php 95.12% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #890      +/-   ##
============================================
- Coverage     99.63%   99.60%   -0.04%     
+ Complexity     1537     1518      -19     
============================================
  Files            81       81              
  Lines          3809     3753      -56     
============================================
- Hits           3795     3738      -57     
- Misses           14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit d04a9c4 into master Oct 18, 2024
3 checks passed
@Tigrov Tigrov deleted the remove-load-from-column branch October 18, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants