fix(prepareTotalCount): infinite loop #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to yiisoft#134 and yiisoft#201. There is currently an infinite loop that happens when following method is called before getting any results from ElasticSearch: ``` prepareModels() ->getPagination() ->prepareTotalCount() ->getQueryResults() ->prepare() ->prepareModels() ``` It seems the infinite loop issue has already been fixed at some point, but then reverted by yiisoft@58466a8. This PR tries a different fix to the same issue by simply ensuring `prepareTotalCount()` to request the number from the database in case we have no available query response, the exact same way it was done with core `ActiveDataProvider::prepareTotalCount()` for SQL databases, Mongo and Sphinx extensions.
|
@tunecino can you update Yii to latest version and re-check? The code was reverted because that change in the core was reverted. |
|
Oops! The project was way behind latest release. All works fine now after core framework being upgraded from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #134 and #201.
There is currently an infinite loop that happens when following method is called before getting any results from ElasticSearch:
It seems the infinite loop issue has already been fixed at some point, but then reverted by 58466a8.
This PR tries a different fix to the same issue by simply ensuring
prepareTotalCount()to request the number from database in case there is no available query response, the exact same way it was done with coreActiveDataProvider::prepareTotalCount()for SQL databases, Mongo and Sphinx extensions.