-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for pointer compression through Electron #206
base: main
Are you sure you want to change the base?
Conversation
Nice addition. This inspires me to explore a way to directly use vscode as node runtime. I found that the official built vscode uses a internal version of node runtime as shown in its {
...
"checksumFailMoreInfoUrl": "https://go.microsoft.com/fwlink/?LinkId=828886",
"electronRepository": "Microsoft/vscode-electron-prebuilt",
"nodejsRepository": "Microsoft/vscode-node",
"settingsSearchUrl": "https://bingsettingssearch.trafficmanager.net/api/Search",
...
} The I tested on Linux and successfully found a way to use vscode as node runtime. It is very similar to the way you mentioned to use Electron. Just point the nodePath to the following script: #!/bin/bash
VSCODE_PATH="/path/to/vscode_installation"
export ELECTRON_RUN_AS_NODE=1
exec "$VSCODE_PATH"/code "$@" I have not done comprehensive tests on this, but I think this might be interesting for you and others who want identical ts development experience as in vscode. |
@yioneko Does this work on macOS? I set nodePath in
but I also open VS Code instance with tsserver.js text file |
@quang-dx make sure you have the env var |
Can you share your nodePath config on macos?
and start nvim with
|
@quang-dx hm, my setup is identical with the exception of I am not certain this is related. It seems like you get an exception from eslint which from my understanding should run as a separate LSP. Does it work with the default config when full node is used? |
On arch linux if you execute: Just point the nodePath to the script yioneko mentions like:
Can't help you for mac! |
Following this issue I did some testing and found Electron to be the most reliable way of getting Node with pointer compression. So far, I only tested on the latest macOS but I don't see why it shouldn't work on other platforms.
Thank you for this awesome library!