Prevent JS error Cannot read properties of undefined under Hyva #181

yireo · Jul 21, 2023 · 7fd59cd · 7fd59cd
1 parent 7a91338
commit 7fd59cd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.5.6] - 21 July 2023
+### Fixed
+- Prevent JS error `Cannot read properties of undefined` under Hyva #181
+
 ## [3.5.5] - 21 July 2023
 ### Fixed
 - Make sure that shipment code is added, if missing in address

diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name": "yireo/magento2-googletagmanager2",
-  "version": "3.5.5",
+  "version": "3.5.6",
   "license": "OSL-3.0",
   "type": "magento2-module",
   "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",

diff --git a/view/frontend/templates/hyva/script-additions.phtml b/view/frontend/templates/hyva/script-additions.phtml
@@ -60,10 +60,12 @@ $commons = $block->getCommonsViewModel();
                         mageCacheStorage = JSON.parse(mageCacheStorage);
                     }
 
-                    if (typeof mageCacheStorage.cart.gtm_events[eventId] !== undefined) {
+                    if (mageCacheStorage !== null &&
+                        typeof mageCacheStorage.cart !== undefined &&
+                        typeof mageCacheStorage.cart.gtm_events[eventId] !== undefined) {
                         delete mageCacheStorage.cart.gtm_events[eventId];
                     }
-                    
+
                     window.localStorage.setItem('mage-cache-storage', JSON.stringify(mageCacheStorage));
                 }
             }