General: Expose cleanup plugin settings

[fabiaserra]

Changelog Description

Expose the clean up plugins settings so they can be enabled/disabled.

This also exposes the optional key on all the clean up plugins so they could be optionally disabled during the publish. However, is the optional key having any effect in the new publisher?

Before

After

Testing notes:

1. Open the Studio Settings and disable the Explicit Clean up plugin

[Minkiu]

Haven't tested, but the code looks good.

[iLLiCiTiT]

Open the Studio Settings and disable the Explicit Clean up plugin

I'm sorry, I'm looking at this PR, and I forgot what was the reason to have option to disable the plugin?

[fabiaserra]

Open the Studio Settings and disable the Explicit Clean up plugin

I'm sorry, I'm looking at this PR, and I forgot what was the reason to have option to disable the plugin?

Because I didn't want any plugins to "explicitly" delete anything, I wanted to be the one that "explicitly" chose when I actually want things to be deleted so I wanted to have the option to disable the plugin

[fabiaserra]

Open the Studio Settings and disable the Explicit Clean up plugin

I'm sorry, I'm looking at this PR, and I forgot what was the reason to have option to disable the plugin?

Because I didn't want any plugins to "explicitly" delete anything, I wanted to be the one that "explicitly" chose when I actually want things to be deleted so I wanted to have the option to disable the plugin

It's been that long though that I no longer know if it still has any impact on my fork but I do remember experiencing some files being deleted due to the Explicit Clean Up that I actually didn't want deleted

[iLLiCiTiT]

It's been that long though that I no longer know if it still has any impact on my fork but I do remember experiencing some files being deleted due to the Explicit Clean Up that I actually didn't want deleted

Can you please revisit that? Because I know we had issues and they should be resolved now. I don't think it's good idea to have setting to disable this plugin.

[BigRoy]

Does this PR allow me to disable the feature? that on a render publish from deadline that it DELETES the source render files? There've been quite a few times where one machine messed up in the render - the sequence got published; all source renders were deleted and we now have to re-render the full sequence instead of just 2 frames to publish it again. Drives us mad.

How can we disable the feature to remove the "render files" from the work/staging area - in our case referring to Maya + Fusion. Is there a setting for that somewhere?

[fabiaserra]

Does this PR allow me to disable the feature? that on a render publish from deadline that it DELETES the source render files? There've been quite a few times where one machine messed up in the render - the sequence got published; all source renders were deleted and we now have to re-render the full sequence instead of just 2 frames to publish it again. Drives us mad.

How can we disable the feature to remove the "render files" from the work/staging area - in our case referring to Maya + Fusion. Is there a setting for that somewhere?

Right? I feel the same way, I want to have full control of when files get deleted as I've been in the same situation where in the farm the staging temporary files get deleted and it would have been very useful to be able to toggle that off so I can debug what happened or pick it up from those intermediate files

[fabiaserra]

Does this PR allow me to disable the feature? that on a render publish from deadline that it DELETES the source render files? There've been quite a few times where one machine messed up in the render - the sequence got published; all source renders were deleted and we now have to re-render the full sequence instead of just 2 frames to publish it again. Drives us mad.
How can we disable the feature to remove the "render files" from the work/staging area - in our case referring to Maya + Fusion. Is there a setting for that somewhere?

Right? I feel the same way, I want to have full control of when files get deleted as I've been in the same situation where in the farm the staging temporary files get deleted and it would have been very useful to be able to toggle that off so I can debug what happened or pick it up from those intermediate files

I owe @iLLiCiTiT a test to confirm whether these changes actually have any effect

[mkolar]

Boys, because we're splitting OpenPype into ayon-core and individual host addons, this PR would have to be re-created to target one of those. Also it probably needs to be properly re-validated :)

We're closing it down, but we'll he happy for a new PR to ynput/ayon-core repository once it's up.