-
Notifications
You must be signed in to change notification settings - Fork 128
Maya: abc options for Pointcache/Animation family - OP-5920 #5173
Maya: abc options for Pointcache/Animation family - OP-5920 #5173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about exposing ALL of this to the artist? I believe @mkolar recommended against this some time ago?
Additionally, I'd say this effort is better spent doing this against the new publisher too since this will basically break / be lost once that's merged.
Its been requested by a client.
I agree, but I dont think we can wait for the merge of the new publisher. |
It's also backwards incompatible. I care less about existing project settings (an admin can fix that once) but all legacy instances using the old attribute names for I understood from @antirotor that there's a big push to get maya on the new publisher for OP 3.16 so it might be coming soon too? |
Cool, we can account for that. |
I'm not 100% sure what you are asking, but I think the issue might be overridden values in the publisher. When you have existing values in the publisher that is saved to the workfile, it wont get updated by the values from the settings. @LiborBatek does this resolve your issue? |
Well I was more refering to Does this make sense now? |
So this is what I've tested successfully:
@LiborBatek could you take me through what you are doing and expecting to happen? |
@LiborBatek in step 4, do you have the custom attributes from the project settings in the publisher?
@LiborBatek in step 5, what loader are you using? |
My Publish Instance looks like this, just without those custom attribs marked in red (when kept empty as in step 4, no custom attribs written).... ...so when performing step 7 (filling in those custom attribs manually) it looks exactly like this scrngrab
Im using |
Could you try loading in another version of Newly created instance should get the custom attributes from the settings, so it should not be empty. |
After discussing with @LiborBatek and the troubles he's had with keeping with the logic, I've implemented a optional validator that'll keep the instance alembic attributes in sync with the settings. The case this should solve is when you have a rig in production which you need a certain Maya attribute published along with the alembic. You can publish the rig with the Maya attribute, but because the animation instances have already "baked" their alembic export options into the workfiles, the new required attribute setting wont get exported. |
Hmm well - but that would mean that by default anything that's set as "user editable" would essentially be 'blocked' from editing by default by the validator. So whenever they are deviating from the defaults on purpose they are also required to disable the validator? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works as expected and now also Validate Alembic Options Defaults
kicks in when attribs not propagated or set by user and differ.
Repair works well too
When matching all publish ok. Also tested with asset without any custom attribs and vice versa. Also tested when loaded in the blank workfile ...all good!
@antirotor @mkolar still having request changes or can be merged now? all seems working well from my testing |
@BigRoy yeah, that was the only way I could see how we could be able to propagate changes to existing instances. Otherwise artists wont be notified of any changes to the settings and because the instances publish attributes are baked into the workfile, they never receive the updated settings. |
@LiborBatek this will need an AYON port first before merging. |
I would likely disable the validator on our end but I see your standpoint. Being able to see what's non default would greatly help - 100%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, port to AYON needed as stated.
@antirotor port PR is already done, so this can be merged; ynput/ayon-core#336 |
…cache-Animation-family
Changelog Description
Add all options for alembic extraction on
pointcache
andanimation
families.Testing notes:
Dependencies:
#5297
#5303