Use colorspace data when creating thumbnail.

[tokejepsen]

Changelog Description

Thumbnail creation was not using the colorspace data to correct convert.

Testing notes:

1. Create a render or review.
2. Publish and verify thumbnail is correct color.

Hosts

• Nuke
  • Render
  • Review
• Maya
  • Render
  • Review
• Houdini
  • Render
  • Review
• Fusion
  • Render
  • Review
• Blender
  • Render
  • Review
• 3dsmax
  • Render
  • Review
• Flame
  • Render
  • Review
• Harmony
  • Render
  • Review
• Tvpaint
  • Render
  • Review
• Photoshop
  • Render
  • Review
• AE
  • Render
  • Review
• Celaction
  • Render
  • Review
• Unreal
  • Render
  • Review
• Hiero
  • Render
  • Review

This PR is now developed by @jakubjezek001

[BigRoy]

Testing notes should likely include testing all DCCs that produce thumbnails? And likely aside of deadline rendering also playblast reviews?

[ClementHector]

I tested for review with render familly, and Thumbnail creation now use the right colorspace data to convert.

[tokejepsen]

Testing notes should likely include testing all DCCs that produce thumbnails? And likely aside of deadline rendering also playblast reviews?

Have updated the description with hosts and families to test.

[LiborBatek]

I did test Maya rendering and publish and it seems there is a slight color shift.

Been using OP OCIO config with ACEScg

[tokejepsen]

@LiborBatek how are you viewing the render and thumbnail?

[LiborBatek]

@LiborBatek how are you viewing the render and thumbnail?

ordinary moviePlayer like VLC and XnView for stills

But I guess it should work in any media player, right? It should be always baked into sRGB no matter what source color space.

I can imagine it could be just difference between sRGB and Rec709 view color space...

Here is the reviewable loaded into Nuke and its pretty obvious they differ by those...

RenderCompare.mp4

[LiborBatek]

My conclusion is that thumbnail and movie are in Rec709 not sRGB.

If I look how the raw exr render looks with sRGB view in NUKE and our reviewables are washed out when also looking via sRGB view.

[tokejepsen]

@LiborBatek what colorspace are you rendering to from Maya? Guessing ACEScg?
Are you interpreting the EXRs as ACEScg?
Looks like your Nuke setup is not using OCIO?

[LiborBatek]

@LiborBatek what colorspace are you rendering to from Maya? Guessing ACEScg? Are you interpreting the EXRs as ACEScg? Looks like your Nuke setup is not using OCIO?

Yeah as you could see on scrn above ....it is ACEScg.

You are right! ...forgot switch Nuke to the custom OCIO config. Will do and check again...now being default linear/sRGB.

But still...those Reviewables looks washed out compared to native RenderView in Maya with OCIO set....so still an issue.

[moonyuet]

Just do simple test to see whether it breaks the code, so I tested with png. The colorspace seems to match the one which does in manual playblast.
3dsmax 2024 works as expected(they are with OCIO config in the latest version)

blender seems to not quite match the color(but the color is a bit off?), I use blender 3.3.6

I also tested in Houdini successfully it doesn't break the code yet. But as there is a PR to implement hou ocio colorspace, so I dont do further test for it.
I will do some tests with exr too.

[tokejepsen]

@moonyuet does 3ds max review also work?

[LiborBatek]

@tokejepsen 3dsmax Review seems working. However I had to turn custom OCIO config file manually...

@jakubjezek001 seems like 3dsmax host doesnt take OP custom OCIO config file at the startup and need to be switched manually via max UI.

I had to switch from default Gamma Workflow to OCIO Custom ...also seems like beta feature in 3dsmax

[LiborBatek]

Did create an Issue for starting max without OCIO config predefined...

#5473

[ClementHector]

Can you add Hiero in the software list?

[BigRoy]

Can you add Hiero in the software list?

I assume you mean the checkboxes in the PR description. If so, done.

[jakubjezek001]

Task linked: OP-6659 Maya: thumbnail color space

[jakubjezek001]

I have updated this PR to latest changes from recent develop.

• Converted colorspaceData key as optional for oiiotools processing. If representation is missing colorspaceData it will fall back to FFMPEG processing.
• Some hosts are not included Display and View into colorspaceData so we have to add those only as optional. The question is if we should be adding target colorspace instead and find the way to pass it from either from settings or upstream from ExtractOIIOTranscode. At the moment the plugin settings is having only available FFMPEG related inputs and I am assuming we should have the same for OIIO
  

[jakubjezek001]

closing in favor of #5938