Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Max: Optional Renderable Camera Validator for Render Instance #5286

Merged
merged 14 commits into from
Sep 1, 2023

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Jul 13, 2023

Changelog Description

Optional validation to check on renderable camera being set up correctly for deadline submission.
If not being set up correctly, it wont pass the validation and user can perform repair actions.

Additional info

  1. Render instance won't include the max content validator
  2. there would be a change after multiple render camera supports for 3dsmax #5124 when batch renderlayer being introduced.

Testing notes:

  1. Launch 3dsmax via OP
  2. Create empty render instance
  3. If no renderable camera set, it won't pass the validation
  4. Repair it
  5. it pops up the menu to allow you to choose your preferred camera and pass the validation

@moonyuet moonyuet requested review from antirotor and LiborBatek July 13, 2023 07:33
@ynbot
Copy link
Contributor

ynbot commented Jul 13, 2023

Task linked: OP-6356 3dsamx: empty render instance

@ynbot ynbot added type: bug Something isn't working host: 3dsmax Autodesk 3dsmax size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jul 13, 2023
@LiborBatek LiborBatek changed the title Max: Optional Viewport Camera for render instnace Max: Optional Viewport Camera for Render Instance Jul 13, 2023
@moonyuet moonyuet requested a review from m-u-r-p-h-y July 18, 2023 06:38
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did follow the testing steps and got correct validate error
image

and my render settings before Repair action

image

After it stays the Render Settings same but validates ok and can be Published (I have added the default Camera001 to the scene tho.
image

Seems it checked the camera exists in the scene aka workfile but was not set correctly as rendering camera tho.
Here are render settings afterwards:
image
Still not set as render cam.

The Repair action did not set it correctly as a Render Camera tho.

@moonyuet moonyuet requested a review from LiborBatek August 22, 2023 04:48
@LiborBatek
Copy link
Member

During testing it again Im getting for some reason this error during Publish:
image

Not sure whats going on...

@moonyuet
Copy link
Member Author

During testing it again Im getting for some reason this error during Publish: image

Not sure whats going on...

there is a repair action for this to fix the naming of how the renderlayer sets.

@moonyuet
Copy link
Member Author

moonyuet commented Aug 22, 2023

@LiborBatek this is helpful for your case if you have more than one validator errored out.

Recording.2023-08-22.160406.mp4

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now when no camera present in the scene the validator correctly fails and if Repair action triggered warning arise if no camera was found.
image

If Camera exists in the scene but isnt set as View to Render then Repair action will set it as renderable and Publish finnishes ok.
image

@moonyuet
Copy link
Member Author

@antirotor would you mind to check on the code before the merge? Thanks!

@LiborBatek LiborBatek removed the request for review from m-u-r-p-h-y August 28, 2023 14:16
@moonyuet moonyuet changed the title Max: Optional Viewport Camera for Render Instance Max: Optional Renderable Camera Validator for Render Instance Aug 31, 2023
Copy link
Contributor

@Minkiu Minkiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it but code looks good.

@moonyuet
Copy link
Member Author

@LiborBatek Can you test again for double check before merging?

@LiborBatek LiborBatek self-requested a review September 1, 2023 07:35
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator works fine
image

And when just single camera present, Repair will correctly set it as Renderable if multiple cameras present, pop up window will show up so user can set the one he want to be set as renderable.

All working fine.

@LiborBatek LiborBatek merged commit 9cf21b7 into develop Sep 1, 2023
2 checks passed
@ynbot ynbot added this to the next-patch milestone Sep 1, 2023
@mkolar mkolar deleted the bugfix/OP-6356_3dsamx-empty-render-instance branch October 4, 2023 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: 3dsmax Autodesk 3dsmax size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants