-
Notifications
You must be signed in to change notification settings - Fork 128
Max: Optional Renderable Camera Validator for Render Instance #5286
Max: Optional Renderable Camera Validator for Render Instance #5286
Conversation
Task linked: OP-6356 3dsamx: empty render instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did follow the testing steps and got correct validate error
and my render settings before Repair
action
After it stays the Render Settings same but validates ok and can be Published (I have added the default Camera001
to the scene tho.
Seems it checked the camera exists in the scene aka workfile but was not set correctly as rendering camera tho.
Here are render settings afterwards:
Still not set as render cam.
The Repair
action did not set it correctly as a Render Camera
tho.
@LiborBatek this is helpful for your case if you have more than one validator errored out. Recording.2023-08-22.160406.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antirotor would you mind to check on the code before the merge? Thanks! |
openpype/modules/deadline/plugins/publish/submit_max_deadline.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it but code looks good.
@LiborBatek Can you test again for double check before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog Description
Optional validation to check on renderable camera being set up correctly for deadline submission.
If not being set up correctly, it wont pass the validation and user can perform repair actions.
Additional info
Testing notes: